-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Toolbar 3000 changes #18671
Merged
Merged
feat: Toolbar 3000 changes #18671
Changes from 22 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
6caaea9
Modified buttons to be custom
benjackwhite 6c78a49
More changes
benjackwhite 1256e1e
Fixes
benjackwhite 59129b9
Update UI snapshots for `chromium` (2)
github-actions[bot] b651341
Added our own dragging logic
benjackwhite e7647f4
Merge branch 'feat/toolbar-3000-changes' of github.com:PostHog/postho…
benjackwhite 1474335
Bunch of changes
benjackwhite cd13456
Fixes for hedgehog
benjackwhite cd7408d
Update UI snapshots for `chromium` (2)
github-actions[bot] 6f22c69
Fixed up hedgehog actor
benjackwhite d01dcca
Merge branch 'feat/toolbar-3000-changes' of github.com:PostHog/postho…
benjackwhite c57f991
Update UI snapshots for `chromium` (2)
github-actions[bot] 26e5f6c
Update UI snapshots for `chromium` (2)
github-actions[bot] 77543e6
Fixes
benjackwhite f08440f
Fix
benjackwhite 108e012
Fixed up toolbar rendering
benjackwhite 113a0b1
fixes
benjackwhite 964bea1
Fixes
benjackwhite 4e90d2a
Fix dragging state
benjackwhite 27cfd50
Fix padding
benjackwhite b9d3642
Merge branch 'feat/toolbar-3000' into feat/toolbar-3000-changes
benjackwhite 0798bf4
Fix
benjackwhite 1cbedf5
Tidying
benjackwhite a5952c3
Fixes to styles and stories
benjackwhite a85f9d6
Fix flashing issue
benjackwhite 6d2f7b0
Fixed button for dragging rules
benjackwhite 06b8d97
Fix
benjackwhite 7084782
Fix
benjackwhite 1b5862c
Update UI snapshots for `chromium` (1)
github-actions[bot] d9f7fbc
Update UI snapshots for `chromium` (2)
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-3.85 KB
(74%)
frontend/__snapshots__/scenes-other-toolbar-components-3000--actions-dark-mode.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-3.53 KB
(78%)
...tend/__snapshots__/scenes-other-toolbar-components-3000--actions-light-mode.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-9.5 KB
(51%)
...hots__/scenes-other-toolbar-components-3000--actions-with-results-dark-mode.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-9.08 KB
(55%)
...ots__/scenes-other-toolbar-components-3000--actions-with-results-light-mode.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+270 Bytes
(100%)
...nd/__snapshots__/scenes-other-toolbar-components-3000--actions-with-results.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+10 Bytes
(100%)
frontend/__snapshots__/scenes-other-toolbar-components-3000--actions.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-19.2 KB
(37%)
frontend/__snapshots__/scenes-other-toolbar-components-3000--flags-dark-mode.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-19 KB
(39%)
frontend/__snapshots__/scenes-other-toolbar-components-3000--flags-light-mode.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-807 Bytes
(97%)
frontend/__snapshots__/scenes-other-toolbar-components-3000--flags.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
benjackwhite marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,28 @@ | ||
import { useValues } from 'kea' | ||
import { Elements } from '~/toolbar/elements/Elements' | ||
import { DraggableButton } from '~/toolbar/button/DraggableButton' | ||
import { toolbarLogic } from '~/toolbar/toolbarLogic' | ||
import { toolbarLogic } from './toolbarLogic' | ||
import { Elements } from './elements/Elements' | ||
import { Fade } from 'lib/components/Fade/Fade' | ||
import { toolbarButtonLogic } from './button/toolbarButtonLogic' | ||
import { HedgehogButton } from './button/HedgehogButton' | ||
import { Toolbar3000 } from './button/Toolbar3000' | ||
|
||
export function ToolbarContainer(): JSX.Element { | ||
const { buttonVisible } = useValues(toolbarLogic) | ||
const { theme } = useValues(toolbarButtonLogic) | ||
|
||
// KLUDGE: if we put theme directly on the div then | ||
// linting and typescript complain about it not being | ||
// a valid attribute. So we put it in a variable and | ||
// spread it in. 🤷 | ||
const themeProps = { theme } | ||
|
||
return ( | ||
<Fade visible={buttonVisible} className="toolbar-global-fade-container ph-no-capture posthog-3000"> | ||
<Elements /> | ||
<DraggableButton /> | ||
<div id="button-toolbar" className="ph-no-capture posthog-3000" {...themeProps}> | ||
<Toolbar3000 /> | ||
</div> | ||
<HedgehogButton /> | ||
</Fade> | ||
) | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
┻┳|
┻┳|
┳┻|
┳┻|
┻┳|
┻┳|
┳┻|
┳┻|
┻┳|
┳┻|
┻┳|
┳┻| _
┻┳| •.•) [I'm hiding off-screen]
┳┻|⊂ノ
┻┳|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed these!