fix: LTS playback issues #17498

pauldambra · 2023-09-18T13:38:46Z

We're not able to load "original" version LTS files

This

when you load an original version LTS blob
converts it to the latest version
and saves it in the correct new location
to avoid putting delete behind an API call it tags converted legacy objects so we can batch delete them (in future)

posthog-bot · 2023-09-18T13:38:59Z

Hey @pauldambra! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

posthog-bot · 2023-09-18T14:56:45Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2023-09-18T15:10:48Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

…ing doesn't play

posthog-bot · 2023-09-18T18:07:23Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2023-09-18T18:18:59Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

pauldambra · 2023-09-18T20:29:17Z

posthog/session_recordings/session_recording_api.py

@@ -272,89 +259,20 @@ def _snapshots_v2(self, request: request.Request):
            SNAPSHOT_SOURCE_REQUESTED.labels(source=source).inc()

        if not source:


I couldn't cope with everything going on here 😅

Tried to separate the arrangement and the work...

pauldambra · 2023-09-18T20:36:48Z

frontend/__snapshots__/scenes-app-recordings--recordings-play-list-no-pinned-recordings.png

Hmmm: we went through multiple commits to get to a diff that appears to replace an image with itself

from "correct" to a "buffering"

from "buffering" to "correct"

from "correct" to "ready to play black background"

from "ready to play black background" to "correct"

It's nice to have a recording in this snapshot as a test that we can render a recording as expected, but this is super flappy

posthog-bot · 2023-09-18T20:37:13Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2023-09-18T20:48:26Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2023-09-19T16:45:25Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2023-09-19T16:58:36Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

pauldambra · 2023-09-21T12:23:13Z

resolved in other PRs

copy over

932cc6d

pauldambra mentioned this pull request Sep 18, 2023

Fix: LTS playback issues #17497

Closed

pauldambra and others added 2 commits September 18, 2023 15:43

unexpected eof

999fc17

Update UI snapshots for chromium (1)

098a740

Update UI snapshots for chromium (1)

a004dcc

pauldambra and others added 3 commits September 18, 2023 18:56

this 'successfully' loads json into the browser - although the record…

f598d88

…ing doesn't play

Merge branch 'master' into fix/lts-playback-with-new-structure

e7b39de

Update UI snapshots for chromium (1)

bd1595c

Update UI snapshots for chromium (1)

ef3ab47

pauldambra added 2 commits September 18, 2023 20:40

separate the arrangement and the work

c31e86e

fix

8d3ff61

pauldambra commented Sep 18, 2023

View reviewed changes

pauldambra requested a review from benjackwhite September 18, 2023 20:32

Update UI snapshots for chromium (1)

6868fac

pauldambra commented Sep 18, 2023

View reviewed changes

pauldambra changed the title ~~copy over~~ fix: LTS playback issues Sep 18, 2023

Update UI snapshots for chromium (1)

15985e8

pauldambra added 6 commits September 19, 2023 13:16

wat

c324784

lazy version

a79dd1c

Merge branch 'master' into fix/lts-playback-with-new-structure

3921a29

and now gzip

f0d1c72

fiddling

df9d37c

test for the entire content preparation

3e722f2

pauldambra marked this pull request as ready for review September 19, 2023 16:44

Update UI snapshots for chromium (1)

82cfc11

Update UI snapshots for chromium (1)

b90780a

Update UI snapshots for chromium (1)

c58a842

This was referenced Sep 20, 2023

fix: lts playback for blobby versioned files #17545

Merged

fix: lts loading with in-place conversion #17561

Merged

pauldambra closed this Sep 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: LTS playback issues #17498

fix: LTS playback issues #17498

pauldambra commented Sep 18, 2023 •

edited

Loading

posthog-bot commented Sep 18, 2023

posthog-bot commented Sep 18, 2023

posthog-bot commented Sep 18, 2023

posthog-bot commented Sep 18, 2023

posthog-bot commented Sep 18, 2023

pauldambra Sep 18, 2023

pauldambra Sep 18, 2023

posthog-bot commented Sep 18, 2023

posthog-bot commented Sep 18, 2023

posthog-bot commented Sep 19, 2023

posthog-bot commented Sep 19, 2023

pauldambra commented Sep 21, 2023

		@@ -272,89 +259,20 @@ def _snapshots_v2(self, request: request.Request):
		SNAPSHOT_SOURCE_REQUESTED.labels(source=source).inc()

		if not source:

fix: LTS playback issues #17498

fix: LTS playback issues #17498

Conversation

pauldambra commented Sep 18, 2023 • edited Loading

posthog-bot commented Sep 18, 2023

posthog-bot commented Sep 18, 2023

📸 UI snapshots have been updated

posthog-bot commented Sep 18, 2023

📸 UI snapshots have been updated

posthog-bot commented Sep 18, 2023

📸 UI snapshots have been updated

posthog-bot commented Sep 18, 2023

📸 UI snapshots have been updated

pauldambra Sep 18, 2023

Choose a reason for hiding this comment

pauldambra Sep 18, 2023

Choose a reason for hiding this comment

posthog-bot commented Sep 18, 2023

📸 UI snapshots have been updated

posthog-bot commented Sep 18, 2023

📸 UI snapshots have been updated

posthog-bot commented Sep 19, 2023

📸 UI snapshots have been updated

posthog-bot commented Sep 19, 2023

📸 UI snapshots have been updated

pauldambra commented Sep 21, 2023

pauldambra commented Sep 18, 2023 •

edited

Loading