fix: lts playback for blobby versioned files #17545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
commented
Sep 20, 2023
|
|
||
| if not blob_keys and recording.storage_version == "2023-08-01": | ||
| if recording.object_storage_path and recording.storage_version == "2023-08-01": |
There was a problem hiding this comment.
this leaves us broken for older version files but we're following up with that. those files need processing anyway before they can be used
benjackwhite
approved these changes
Sep 20, 2023
daibhin
pushed a commit
that referenced
this pull request
Sep 21, 2023
* fix: lts playback for blobby versioned files * and when loading snapshots too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several fixes needed see #17498
This just changes the snapshots API to use data in LTS storage whenever a path is present on the recording object