Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lts loading with in-place conversion #17561

Merged
merged 3 commits into from
Sep 21, 2023
Merged

fix: lts loading with in-place conversion #17561

merged 3 commits into from
Sep 21, 2023

Conversation

pauldambra
Copy link
Member

lifts the changes out of #17498 without the refactoring

When loading an OG recording it first converts the content into the new format and location

Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's try it and fix forward if things still don't load.

@pauldambra pauldambra merged commit f72d910 into master Sep 21, 2023
@pauldambra pauldambra deleted the fix/lts-step-3 branch September 21, 2023 11:01
daibhin pushed a commit that referenced this pull request Sep 21, 2023
* can save new content to a recording

* and in place convert

* correct test assertion
daibhin pushed a commit that referenced this pull request Sep 21, 2023
* can save new content to a recording

* and in place convert

* correct test assertion
@sentry-io
Copy link

sentry-io bot commented Sep 28, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ObjectStorageError: tag failed /api/projects/{parent_lookup_team_id}/session_r... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants