chore: open / close notebook widgets #17375
Conversation
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
| isShowingSidebar: [ | ||
| false, | ||
| { | ||
| setSelectedNodeId: () => false, |
There was a problem hiding this comment.
I don't think this should be here anymore. If we are changing to a user initiated opening then I think we should leave it open until either the setting is closed or the source node is deleted.
There was a problem hiding this comment.
Good call. I made a change to leave the sidebar open except in the case when you click a non-custom node (e.g. paragraph)
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
| @@ -99,9 +97,7 @@ export function Notebook({ shortId, editable = false, initialAutofocus = null }: | |||
| ) : null} | |||
|
|
|||
| <div className="flex flex-1 justify-center space-x-2"> | |||
| <FlaggedFeature flag={FEATURE_FLAGS.NOTEBOOK_SETTINGS_WIDGETS}> | |||
There was a problem hiding this comment.
Removing this because settings widgets are much more stable (and necessary now) given insights are working
| @@ -99,9 +97,7 @@ export function Notebook({ shortId, editable = false, initialAutofocus = null }: | |||
| ) : null} | |||
|
|
|||
| <div className="flex flex-1 justify-center space-x-2"> | |||
There was a problem hiding this comment.
I don't know if this was always the case but the space-x-2 causes a gap when there are no widgets showing... (see the snapshot diff)
There was a problem hiding this comment.
There is still some weirdness around the way things sometimes open and sometimes not. I have an idea for what we can do here so I'm tempted to say lets merge and then improve afterwards with a slightly altered concept that will also enable another feature I wanted to add...
| <LemonButton | ||
| onClick={() => setWidgetsVisible(true)} | ||
| onClick={() => setIsShowingSidebar(true)} |
There was a problem hiding this comment.
I feel like this should toggle, rather than just showing. And it would be great if it could have an "active" state if open.
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Problem
The opening and closing of the sidebar in notebooks is not smooth right now
Changes
How did you test this code?
None