-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: open / close notebook widgets #17375
Changes from 18 commits
923c095
fbaa8d8
b306117
5411813
d5b7939
c7dade6
b7faf60
a836b78
6c4b3e1
bba72cb
675168a
af079ee
7e190bb
d327e6e
9d715a9
d2c7348
63b3c0c
fd883c7
f2fcbd3
1ff763d
33d201d
632b16e
da3cc83
4067347
fefb59e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,8 +13,6 @@ import { NotebookConflictWarning } from './NotebookConflictWarning' | |
import { NotebookLoadingState } from './NotebookLoadingState' | ||
import { Editor } from './Editor' | ||
import { EditorFocusPosition } from './utils' | ||
import { FlaggedFeature } from 'lib/components/FlaggedFeature' | ||
import { FEATURE_FLAGS } from 'lib/constants' | ||
import { NotebookSidebar } from './NotebookSidebar' | ||
import { ErrorBoundary } from '~/layout/ErrorBoundary' | ||
|
||
|
@@ -99,9 +97,7 @@ export function Notebook({ shortId, editable = false, initialAutofocus = null }: | |
) : null} | ||
|
||
<div className="flex flex-1 justify-center space-x-2"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't know if this was always the case but the space-x-2 causes a gap when there are no widgets showing... (see the snapshot diff) |
||
<FlaggedFeature flag={FEATURE_FLAGS.NOTEBOOK_SETTINGS_WIDGETS}> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removing this because settings widgets are much more stable (and necessary now) given insights are working |
||
<NotebookSidebar /> | ||
</FlaggedFeature> | ||
<NotebookSidebar /> | ||
<ErrorBoundary> | ||
<Editor | ||
initialContent={content} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this should toggle, rather than just showing. And it would be great if it could have an "active" state if open.