feat: saved insights settings in notebooks #17373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daibhin
commented
Sep 11, 2023
| @@ -48,38 +47,6 @@ | |||
| display: block; | |||
| padding-right: 1rem; | |||
| } | |||
| &.anim--enter { | |||
There was a problem hiding this comment.
These styles didn't seem to be used anywhere
daibhin
commented
Sep 11, 2023
| const [dataKey] = useState(() => `DataNode.${uniqueKey || uniqueNodeKey}`) | ||
| const [vizKey] = useState(() => `DataTable.${uniqueNodeKey}`) |
There was a problem hiding this comment.
Needed to revert to an earlier commit because using the same key for the viz & data meant that both representations shared view props e.g. the table was showing up in the settings panel
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
benjackwhite
approved these changes
Sep 12, 2023
|
@benjackwhite both are known issues:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Insights & their settings don't always look great in Notebooks
Changes
Before
After
Before
Before
Before
How did you test this code?
By hand