feat(data-exploration): implement retention insight (fixes #14015) #14019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @thmsobrmlr! 👋 |
34 tasks
thmsobrmlr
changed the title
mariusandra
approved these changes
Feb 2, 2023
| @@ -64,7 +64,7 @@ export function dayjsLocalToTimezone( | |||
| // eslint-disable-next-line @typescript-eslint/no-empty-interface | |||
| export interface Dayjs extends DayjsOriginal {} | |||
|
|
|||
| export type UnitTypeShort = 'd' | 'M' | 'y' | 'h' | 'm' | 's' | 'ms' | |||
| export type UnitTypeShort = 'd' | 'D' | 'M' | 'y' | 'h' | 'm' | 's' | 'ms' | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR converts the retention insight to data exploration, as part of the ongoing effort at PostHog/meta#84. It was one of the easier ones and thus a complete conversion.
Also fixes #14015.
Changes
retentionLogicinto multiple logics that "do one thing well" e.g.retentionTableLogic,retentionLineChartLogicretention-breakdownsfeature flag, as they aren't working (return an empty array at all times or throws)How did you test this code?
Manual testing.