Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-exploration): Ensure query schema sync #14081

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Feb 3, 2023

Problem

Backend CI checks whether posthog/schema.py is in sync with frontend/src/queries/schema.json(the source of truth)… but backend CI intentionally doesn't run when only frontend/* has changed. So we missed that these two files went out of sync in #14019.

Changes

Regenerated schema.py, and made sure this never happens again by adding frontend/src/queries/schema.json as a trigger for backend CI.

@Twixes Twixes requested a review from thmsobrmlr February 3, 2023 15:25
@Twixes Twixes merged commit 2b90826 into master Feb 3, 2023
@Twixes Twixes deleted the fix-schema-check branch February 3, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants