Data Exploration Insights

[thmsobrmlr]

This issue captures the current state of data exploration for insights.

Priorities

• Make refresh work as expected
• Remove legacy code (this should improve quality as well)
• Allow standalone <Query /> nodes / make queries work on debug page

Prio 1: Make refresh work as expected

There are at least two unrelated issues related to refreshes:

1. Previously we've called a different code path when we have a saved insight and the current filters match the saved ones, but there isn't a result https://github.com/PostHog/posthog/blob/master/frontend/src/scenes/insights/insightLogic.ts#L327-L337
2. The "last computed at" property doesn't properly update in all cases Refreshing an insight should update the "last computed at" property posthog#16082

See the list of this issue and verify they are working after fixing the above:

• Example by Andi https://posthog.slack.com/archives/C0368RPHLQH/p1686040276506499
• Customer tickets https://posthog.slack.com/archives/C0368RPHLQH/p1687517358620079

Prio 2: Remove legacy code

• Re-do the heuristics (feat(insights): give refresh a refresh posthog#14178) for refreshing independent of a saved insight (i.e. they should work for new insights as well).
• Replace trendsLogic with trendsDataLogic in all remaining visualization components
• Handle load more for trends with breakdowns via dataNodeLogic
• Remove setFilters calls from all remaining filter components
• Deploy together with a fix for Dashboards insights don't take updated filters into account posthog#16558.
• What is necessary for hidden legend keys to fully get rid of setFilters?
• remove all filters and setFilters from insightLogic
  1. Move hiddenLegendKeys to separate logic (currently handled by insightLogic)
  2. Move highlightSeries to separate logic (currently handled by insightLogic)
  • show_legend
  • hidden_legend_keys
  • reportInsightViewed
  • sampling/global insight filters
  • tbd
• Re-implement the visual changes where the insight metadata moved onto the chart canvas: current -> desired
• Remove non-data-exploration variant of TaxonomicBreakdownFilter
• Remove dead code from insightLogic e.g. loadResults
• Make ExportedInsight based on query
• Replace FilterBasedCardContent with Query?
• Bug: Toggling internal users filter should count as change
• Bug: The user paths insight should not disable the persons modal in card view
• Other Bugs
  • Saved insight in bad state after navigation posthog#16370
  • Navigating away from a saved HogQL insight causes an error posthog#16281
  • Erroring insights should display error message instead of empty state posthog#16091

Longlist of things to clean up (not necessarily now)

• Make ActionFilter and entityFilter logic based on series, not actions and events
• Replace compareFilters with compareQuery and make the function robust wrt defaults and undefined values comparyQuery(a,b, defaults)
• Remove the unfinished retention breakdowns feature
• Delete the feature flag from app.posthog.com
• Clicking save before the query completes -> changes should get saved
• Hidden legend items should get saved with the query
• Prevent requests when only client-side settings change e.g formula: '' vs. formula: undefined, layout, hidden_legend_keys, show_legend
• Remove filter based helpers from frontend/src/scenes/insights/sharedUtils.ts e.g. isTrendsFilter or isFilterWithDisplay
• Remove usage of filtersToQueryNode, queryNodeToFilters, etc. in as many places as possible
• Remove all usages of the cleanFilter function
• Agree on a "final" node schema:
  • rename breakdown to breakdownFilter
  • rename date_from to dateFrom or more generally agree on camel or snake case

[thmsobrmlr]

Closing this in favor of #130