Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data-exploration): replace trendsLogic with trendsDataLogic #16576

Merged
merged 45 commits into from
Jul 18, 2023

Conversation

thmsobrmlr
Copy link
Contributor

@thmsobrmlr thmsobrmlr commented Jul 14, 2023

Problem

Cleanup according to PostHog/meta#84.

Most importantly removing the reliance of anything updating an insight by changing insightLogic.filters enables a fix for the dashboard issue #16558.

Changes

This PR:

How did you test this code?

Manual testing

@thmsobrmlr thmsobrmlr force-pushed the thomas/replace-trends-logic branch from 6381a98 to 57b0f4f Compare July 14, 2023 10:01
@thmsobrmlr thmsobrmlr force-pushed the thomas/replace-trends-logic branch from 4f90003 to 29edb00 Compare July 14, 2023 10:17
@PostHog PostHog deleted a comment from posthog-bot Jul 14, 2023
@PostHog PostHog deleted a comment from posthog-bot Jul 14, 2023
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

6 snapshot changes in total. 0 added, 6 modified, 0 deleted:

  • chromium: 0 added, 6 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

7 snapshot changes in total. 0 added, 7 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (wasn't pushed!)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

6 snapshot changes in total. 0 added, 6 modified, 0 deleted:

  • chromium: 0 added, 6 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@thmsobrmlr thmsobrmlr marked this pull request as ready for review July 17, 2023 15:49
@thmsobrmlr thmsobrmlr requested review from mariusandra and Twixes July 17, 2023 15:59
@thmsobrmlr thmsobrmlr force-pushed the thomas/replace-trends-logic branch from 1ee1de1 to 8a4d99c Compare July 18, 2023 10:10
Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm definitely not able to verify every changed line, but on a higher level it looks very good. Clicking around insights and dashboards, things worked as they should. So 👍 for getting this in.

@thmsobrmlr thmsobrmlr merged commit f6e79c0 into master Jul 18, 2023
@thmsobrmlr thmsobrmlr deleted the thomas/replace-trends-logic branch July 18, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboards insights don't take updated filters into account
3 participants