feat(data-exploration): convert insight display config #14075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thmsobrmlr
changed the base branch from
master
to
data-exploration-retention-insight-3
Base automatically changed from
data-exploration-retention-insight-3
to
master
February 3, 2023 13:18
# Conflicts: # frontend/src/queries/nodes/InsightViz/EditorFilters.tsx # frontend/src/scenes/insights/InsightDisplayConfig.tsx # frontend/src/scenes/insights/insightDataLogic.ts # frontend/src/scenes/saved-insights/SavedInsights.tsx
mariusandra
approved these changes
Feb 6, 2023
There was a problem hiding this comment.
Oh my, showSmoothing is so much cleaner than {isTrendsFilter(filters) && !filters.breakdown_type && !filters.compare && (!filters.display || filters.display === ChartDisplayType.ActionsLineGraph) && featureFlags[FEATURE_FLAGS.SMOOTHING_INTERVAL] 🤣
Looks good to me! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR converts the display insight config (filters above the chart) to data exploration, as part of the ongoing effort at PostHog/meta#84.
Most of the filters already support data exploration in one way or another (full conversion or just calling updateQuery whenever we call setFilters).
How did you test this code?
Manual testing