Tlg0062 harmon #1470

gregorycrane · 2023-07-21T15:03:28Z

Let me know if I should first create a tlg0062-harmon branch on PerseusDL and submit a pull request from that.

I have described the changes in #1469.

There are too many changes to check them manually. I have gone over this a number of times but it is possible I missed something.

It does pass Hooktest.

The next pull request will add the Kilburn and Harmon Greek and English (TLG 53-69), giving us (1) a more recent Greek edition and (2) English translations.

catching up

update

updating my copy of master

lcerrato · 2023-07-21T16:22:54Z

@gregorycrane
Yes, this is why we do smaller PRs when there are extensive changes. (< 10 files each)

One thing I see is that all of the English needs to have the URNs bumped.

lcerrato · 2023-07-21T16:28:14Z

@gregorycrane
I see several issues in the headers just taking a quick look. You have an incorrect <resp> statement, for instance. I believe I mentioned this before? The <resp> is what is shown in the sidebar credits and not where your work is described in detail. That is the change log. The <resp> has only a few standard options.

I think I made earlier suggestions as well? I see some titles and things that may need language changes.

I would recommend just pruning to one set of files so that I can make recommendations for the batch, otherwise I will be making too many edits in this format. I can do that, but it triggers a check every time I make a small change.

Otherwise I can make a checklist here.

lcerrato · 2023-07-21T16:28:46Z

Note, if this closes an issue such as the one referenced above, that should be noted , too.

lcerrato

Misc header irregularities pertaining to credits, such as Perseus staff and release info
missing translator role for Harmon, expanded initials (non-standard), and added brith/death dates (not used)
missing n attributes in cRef (structure will read as "none")
other minor header fixes, HathiTrust, changelog, etc.
incomplete xml:base attributes
notes need language attribute and finer level of language tagging
all English files need to be bumped and changed to appropriate URNs
??

lcerrato · 2023-07-21T16:30:26Z

data/tlg0062/tlg001/__cts__.xml

+   <ti:translation urn="urn:cts:greekLit:tlg0062.tlg001.perseus-eng1" xml:lang="eng" workUrn="urn:cts:greekLit:tlg0062.tlg001">
+      <ti:label xml:lang="eng">Phalaris</ti:label>
+      <ti:description xml:lang="eng">Lucian, Vol. 1. Harmon, A. M., editor. London: William Heinemann, Ltd.; Cambridge, MA: Harvard University Press, 1913.</ti:description>


Harmon is the translator here, not editor so <editor role="translator">

I understand the importance of consistency but expanding the initials helps the reader and I found that information because I needed it. (It took a while to track down the K. in "K. Kilburn"). So I am going to keep that and any birth/death dates I find. Libraries are not consistent on this either.

hey @gregorycrane I think it is that it ends up looking strange in the header and this is one reason for better integration with the catalog where all of this metadata can be found typically.

lcerrato · 2023-07-21T16:31:12Z

data/tlg0062/tlg001/tlg0062.tlg001.perseus-eng1.xml

+<titleStmt>
+<title xml:lang="eng">Phalaris</title>
+<author>Lucian of Samosata</author>
+<editor>Austin Morris Harmon, 1878-1950</editor>


<editor role="translator"> strike years 1878-1950

In the translation files, Harmon has 'role="translator".

He did, however, edit the Greek and so he is just in the Greek files.

We can express the different roles because we have split the Greek and the English -- that is an advantage.

lcerrato · 2023-07-21T16:31:57Z

data/tlg0062/tlg001/tlg0062.tlg001.perseus-eng1.xml

+<author>Lucian of Samosata</author>
+<editor>Austin Morris Harmon, 1878-1950</editor>
+<funder>National Endowment for the Humanities</funder>
+<principal>Gregory Crane</principal>


I add the staff here who were working on texts when the files were created based on the initial year of upload

I assume these are the same as the Greek, but can look this up

lcerrato · 2023-07-21T16:34:03Z

data/tlg0062/tlg001/tlg0062.tlg001.perseus-eng1.xml

+<principal>Gregory Crane</principal>
+<respStmt>
+<persName>Gregory Crane</persName>
+<resp>OCRd, tagged and added initial corrections to  the text</resp>


Please look at the Greek for the correct info here. There should be the other contributors here based on the staff timelines, which I have, and the creation dates. You are describing work that belongs in the change log.

Note this incomplete: We use the original release date, not the update year. Again, I have this info

<publicationStmt> <publisher>Trustees of Tufts University</publisher> <pubPlace>Medford, MA</pubPlace> <authority>Perseus Project</authority> <date type="release" when="2010-12-13">Perseus 4.0</date>

<resp> has limited use for giving credit (Digital proofreader, etc.)--what you are describing is what the change log is for

lcerrato · 2023-07-21T16:36:44Z

data/tlg0062/tlg001/tlg0062.tlg001.perseus-eng1.xml

+<availability>
+<licence target="https://creativecommons.org/licenses/by-sa/4.0/">Available under a Creative Commons Attribution-ShareAlike 4.0 International License</licence>
+</availability>
+<date>2023</date>


should be P4 date: see above

lcerrato · 2023-07-21T16:42:45Z

data/tlg0062/tlg001/tlg0062.tlg001.perseus-grc2.xml

 <sponsor>Perseus Project, Tufts University</sponsor>
 <principal>Gregory Crane</principal>
 <respStmt>
 <resp>Prepared under the supervision of</resp>
 <name>Bridget Almas</name>
 <name>Lisa Cerrato</name>
+<name>Gregory Crane</name>


your name is already here

My name is everywhere as Principal in a ceremonial way. I need different when I toiled over the file myself.

lcerrato · 2023-07-21T16:43:11Z

data/tlg0062/tlg001/tlg0062.tlg001.perseus-grc2.xml

 <sourceDesc>
 <listBibl>
 <biblStruct>
 <monogr>
 <author>Lucian</author>
 <title>Lucian</title>
-<editor>A. M. Harmon</editor>
+<editor>Austin Morris Harmon, 1878-1950</editor>


As above, I would revert to A. M. Harmon, but the years should not be here.

@AlisonBabeu ??

I don't think we've ever put the years here, but at least it should be an easy one to take out! :)

lcerrato · 2023-07-21T16:45:08Z

data/tlg0062/tlg001/tlg0062.tlg001.perseus-grc2.xml

 <encodingDesc>
 <editorialDecl>
 <correction method="silent">
 <p>optical character recognition</p>
 </correction>
 </editorialDecl>
- 
+
 <refsDecl n="CTS">
  <cRefPattern matchPattern="(\w+).(\w+)"


the n attributes are missing here. I discovered this issue after this conversion was completed and was preparing a global fix. PerseusDL/canonical-latinLit#515

lcerrato · 2023-07-21T16:48:14Z

data/tlg0062/tlg001/tlg0062.tlg001.perseus-grc2.xml

 </div>
   <div type="textpart" subtype="section" xml:base="urn:cts:greekLit:tlg0062.tlg001.perseus-grc2:1" n="5">
-    <p rend="align(indent)"> ἐγὼ δὲ ἐνταῦθα ἤδη ὑμᾶς, ὦ Δελφοί, ἐπὶ τοῦ αὐτοῦ δέους νῦν τῷ λογισμῷ γενομένους ἀξιῶ περὶ τῶν τότε πρακτέων μοι συμβουλεῦσαι, ὅτε ἀφύλακτος ὀλίγου δεῖν ληφθεὶς ἐζήτουν τινὰ σωτηρίαν περὶ τῶν παρόντων. πρὸς ὀλίγον οὖν τῇ γνώμῃ ἐς Ἀκράγαντα παρʼ ἐμὲ ἀποδημήσαντες καὶ ἰδόντες τὰς παρασκευὰς αὐτῶν καὶ τὰς ἀπειλὰς ἀκούσαντες εἴπατε τί δεῖ ποιεῖν; φιλανθρωπίᾳ χρῆσθαι πρὸς αὐτοὺς ἔτι καὶ φείδεσθαι καὶ ἀνέχεσθαι ὅσον αὐτίκα μελλήσοντα πείσεσθαι τὰ ὕστατα; μᾶλλον δὲ γυμνὴν ἤδη ὑπέχειν τὴν σφαγὴν καὶ τὰ φίλτατα ἐν ὀφθαλμοῖς ὁρᾶν ἀπολλύμενα; ἢ τὰ μὲν τοιαῦτα πάνυ ἠλιθίου τινὸς εἶναι, γενναῖα δὲ καὶ ἀνδρώδη διανοηθέντα καὶ χολὴν ἔμφρονος καὶ ἠδικημένου ἀνδρὸς ἀναλαβόντα μετελθεῖν ἐκείνους, ἐμαυτῷ δὲ ἐκ τῶν ἐνόντων τὴν ἐς τὸ ἐπιὸν ἀσφάλειαν παρασχεῖν; ταῦτʼ οἶδʼ ὅτι συνεβουλεύσατε ἄν.</p>
+    <p rend="align(indent)"> ἐγὼ δὲ ἐνταῦθα ἤδη ὑμᾶς, ὦ Δελφοί, ἐπὶ τοῦ αὐτοῦ δέους νῦν τῷ λογισμῷ γενομένους ἀξιῶ περὶ τῶν τότε πρακτέων μοι συμβουλεῦσαι, ὅτε ἀφύλακτος ὀλίγου δεῖν ληφθεὶς ἐζήτουν τινὰ σωτηρίαν περὶ τῶν παρόντων. πρὸς ὀλίγον οὖν τῇ γνώμῃ ἐς Ἀκράγαντα παρʼ ἐμὲ ἀποδημήσαντες καὶ ἰδόντες τὰς παρασκευὰς αὐτῶν καὶ τὰς ἀπειλὰς ἀκούσαντες εἴπατε τί δεῖ<note type="footnote" n="v.1.p.8.n.1">δεῖ MSS.: ἔδει Cobet.</note> ποιεῖν; φιλανθρωπίᾳ χρῆσθαι πρὸς αὐτοὺς ἔτι καὶ φείδεσθαι καὶ ἀνέχεσθαι ὅσον αὐτίκα μελλήσοντα πείσεσθαι τὰ ὕστατα; μᾶλλον δὲ γυμνὴν ἤδη ὑπέχειν τὴν σφαγὴν καὶ τὰ φίλτατα ἐν ὀφθαλμοῖς ὁρᾶν ἀπολλύμενα; ἢ τὰ μὲν τοιαῦτα πάνυ ἠλιθίου τινὸς εἶναι, γενναῖα δὲ καὶ ἀνδρώδη διανοηθέντα καὶ χολὴν ἔμφρονος καὶ ἠδικημένου ἀνδρὸς ἀναλαβόντα μετελθεῖν ἐκείνους, ἐμαυτῷ δὲ ἐκ τῶν ἐνόντων τὴν ἐς τὸ ἐπιὸν ἀσφάλειαν παρασχεῖν; ταῦτʼ οἶδʼ ὅτι συνεβουλεύσατε ἄν.</p>


We don't generally number notes if they are placed after the word.

you need a note language attribute and to fix the internal language in the notes.

So if the notes are in English or Latin, then the Greek in the note needs tagging. (or vice versa)

<note type="footnote" n="v.1.p.8.n.1">δεῖ MSS.: ἔδει Cobet.</note>

vs

<note type="footnote" n="v.1.p.8.n.1" xml:lang="eng"><foreign xml:lang="grc">δεῖ</foreign> MSS.: <foreign xml:lang="grc">ἔδει</foreign> Cobet.</note>

lcerrato · 2023-07-21T16:49:18Z

data/tlg0062/tlg001/tlg0062.tlg001.perseus-eng1.xml

+<language ident="grc">Greek</language>
+<language ident="lat">Latin</language>
+</langUsage>
+</profileDesc>


missing the change log where you would indicate the EpiDoc and CTS updating

for example
<revisionDesc> <change who="Lisa Cerrato" when="2023-04-10">EpiDoc and CTS conversion and other cleanup</change> </revisionDesc>

lcerrato · 2023-07-21T17:21:22Z

as noted in #1469, I am happy to begin to incorporate fixes (things like the note work will require more effort) but need to know that there is no other simultaneous work here. The PR is too large to risk any conflicts.

Fixes, I would recommend, should be of one type per PR. (So all author/translator name modifications, one pass; change log, a second pass, etc.) for ease of review and error reduction.

Happy to work on this but need to know no one else is doing so.

gregorycrane · 2023-07-21T23:46:02Z

@gregorycrane Yes, this is why we do smaller PRs when there are extensive changes. (< 10 files each)

One thing I see is that all of the English needs to have the URNs bumped.

This is the first version of these translations BUT they translate the Greek. It makes sense to me that that we give the Greek perseus-grc2 and the English perseus-grc2 to help make the relationship clear.

I think all new Lucian materials should stay in the Perseus repo -- its too confusing to split (even if we have done so in the past).

AlisonBabeu · 2023-07-24T17:50:28Z

data/tlg0062/tlg001/tlg0062.tlg001.perseus-eng2.xml

+</titleStmt>
+<publicationStmt>
+<authority>Perseus Digital Library</authority>
+<idno type="filename">tlg0062.tlg001.1st1K-eng1.xml</idno>


You need to update this file name.

AlisonBabeu · 2023-07-24T17:50:52Z

data/tlg0062/tlg001/tlg0062.tlg001.perseus-eng2.xml

+</imprint>
+<biblScope unit="volume">1</biblScope>
+</monogr>
+<ref target="https://hdl.handle.net/2027/uc1.b000604153">The Hathi Trust</ref>


Link is not at the page level for the work.

AlisonBabeu · 2023-07-24T17:51:14Z

data/tlg0062/tlg001/tlg0062.tlg001.perseus-eng2.xml

+</teiHeader>
+<text>
+<body>
+<div type="translation" n="urn:cts:greekLit:tlg0062.tlg001.perseus-eng1" xml:lang="eng">


You also need to update the CTS-URN here to perseus-eng2.

AlisonBabeu · 2023-07-24T17:51:37Z

data/tlg0062/tlg001/__cts__.xml

+
+   <ti:translation urn="urn:cts:greekLit:tlg0062.tlg001.perseus-eng1" xml:lang="eng" workUrn="urn:cts:greekLit:tlg0062.tlg001">


You need to update the CTS-URN here to perseus-eng2.

gregorycrane · 2023-08-02T22:55:40Z

That problem should be fixed. I am going to make a new pull request.

gregorycrane added 6 commits June 4, 2023 10:03

Merge pull request #4 from PerseusDL/master

8d82da9

catching up

Merge pull request #5 from PerseusDL/master

e6bcd4d

update

Merge branch 'PerseusDL:master' into master

0f9bdd0

Merge branch 'PerseusDL:master' into master

eb46c97

Merge pull request #8 from PerseusDL/master

bf0e81c

updating my copy of master

details are listed under the issue tlg0062-Harmon.

2edbfae

lcerrato reviewed Jul 21, 2023

View reviewed changes

lcerrato added enhancement quality control labels Jul 21, 2023

rename

bba16e7

gregorycrane mentioned this pull request Jul 22, 2023

(tlg0018-yonge2) C D Yonge English translations OpenGreekAndLatin/First1KGreek#2753

Open

AlisonBabeu reviewed Jul 24, 2023

View reviewed changes

gregorycrane closed this Aug 2, 2023

gregorycrane deleted the tlg0062-harmon branch August 3, 2023 00:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tlg0062 harmon #1470

Tlg0062 harmon #1470

gregorycrane commented Jul 21, 2023

lcerrato commented Jul 21, 2023

lcerrato commented Jul 21, 2023

lcerrato commented Jul 21, 2023

lcerrato left a comment

lcerrato Jul 21, 2023 •

edited

Loading

gregorycrane Jul 21, 2023

AlisonBabeu Jul 23, 2023

lcerrato Jul 21, 2023

gregorycrane Jul 21, 2023

lcerrato Jul 21, 2023

lcerrato Jul 21, 2023

lcerrato Jul 21, 2023

lcerrato Jul 21, 2023

lcerrato Jul 21, 2023 •

edited

Loading

lcerrato Jul 21, 2023

lcerrato Jul 21, 2023

gregorycrane Jul 22, 2023

lcerrato Jul 21, 2023

lcerrato Jul 21, 2023

AlisonBabeu Jul 21, 2023

lcerrato Jul 21, 2023

lcerrato Jul 21, 2023

lcerrato Jul 21, 2023

lcerrato Jul 21, 2023

lcerrato commented Jul 21, 2023

gregorycrane commented Jul 21, 2023

AlisonBabeu Jul 24, 2023

AlisonBabeu Jul 24, 2023

AlisonBabeu Jul 24, 2023

AlisonBabeu Jul 24, 2023

gregorycrane commented Aug 2, 2023


		<ti:translation urn="urn:cts:greekLit:tlg0062.tlg001.perseus-eng1" xml:lang="eng" workUrn="urn:cts:greekLit:tlg0062.tlg001">

Tlg0062 harmon #1470

Tlg0062 harmon #1470

Conversation

gregorycrane commented Jul 21, 2023

lcerrato commented Jul 21, 2023

lcerrato commented Jul 21, 2023

lcerrato commented Jul 21, 2023

lcerrato left a comment

Choose a reason for hiding this comment

lcerrato Jul 21, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lcerrato Jul 21, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lcerrato commented Jul 21, 2023

gregorycrane commented Jul 21, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gregorycrane commented Aug 2, 2023

lcerrato Jul 21, 2023 •

edited

Loading

lcerrato Jul 21, 2023 •

edited

Loading