Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(tlg0018-yonge2) C D Yonge English translations #2753

Open
gregorycrane opened this issue Jul 22, 2023 · 3 comments
Open

(tlg0018-yonge2) C D Yonge English translations #2753

gregorycrane opened this issue Jul 22, 2023 · 3 comments

Comments

@gregorycrane
Copy link
Contributor

gregorycrane commented Jul 22, 2023

I am building a pull request for the Yonge English translations of Philo (new addition). A separate one for the Berlin Greek updated files will follow.

I have gone back over comments from May (#2726) and also for Lucian (PerseusDL/canonical-greekLit#1470). I may have missed something.

Questions

  • What is the release date? Preliminary versions of XML from volumes 1, 2, and 4 were created by Jouve and published in 2014 but that is a very rough base and was not prepared for Perseus. I had to create volume 3 from page images in 2023. I have made the release date 2023 but I could go with 2014 for volumes 1, 2, and 4 (but volume is 2023).

Things I have not changed

  • I think we should always and everywhere where possible expand initials. I have strong feelings on this. The only question is when we get around to expanding initials for all authors we cite. I also think we should include birth and death dates to help with copyright but I have taken those out.

Things I have changed

  • <milestones/> have been moved from the end of a paragraph to the start of the next <div/>
  • footnotes are now merged into the main text with <ref/> tags removed.
  • We have the base elements now in
    tags.
  • <cRefPattern>: I now find none without n attribute
  • We now use Philo Judaeus (although we should update all our files to the more modern Philo of Alexandria)
  • We use the original publisher, Henry G. Bohn (rather than the later George Bell printings)
  • each work has a URL that points to the page on which it begins in a Archive.org scan, e.g., tlg0018.tlg030 has https://archive.org/details/worksphilojudaeu04philuoft/page/61/mode/1up.
  • I could also put tags with links on each page number but the tags can't appear in as many places as tags can.
  • I can't find the controlled vocabulary for tags, but I copied <resp>Digital conversion and editing</resp>
    from a recent file (tlg0550)
  • I have moved more detailed info to the <revisionDesc/>
  • Notes have xml:lang attributes.
  • I am using 1st1k-eng1 which I got from Alison.
  • We now have '<editor role="translator">' for Yonge.
  • I have updated the <ti:translation/> field to follow the standard that we now have. My model was the Greek edition for Philo and tlg0550:
<ti:translation urn="urn:cts:greekLit:tlg0018.tlg002.1st1K-eng1" xml:lang="eng" workUrn="urn:cts:greekLit:tlg0018.tlg002">
<ti:label xml:lang="eng">On the Alegories of the Sacred Laws</ti:label>
<ti:description xml:lang="eng">The works of Philo Judaeus, the contemporary of Josephus, volume 1. Yonge, C. D., translator. London: Bohn. 1854.</ti:description>
</ti:translation>
gregorycrane added a commit to gregorycrane/first1kwork that referenced this issue Jul 22, 2023
@AlisonBabeu
Copy link
Collaborator

hi @gregorycrane so I looked over these two files there. Just two comments on the English file at this point fromme:

1.) You have the titles mixed up in that you have the title of the volume in the header at line 7 (<title xml:lang="eng">The Works of Philo Judaeus</title>), where you should have the title of the individual work.

This should be in the structured bibl section, where you have <title xml:lang="eng">On the Creation of the World</title>, so you just need to reverse those.

  1. You should update the file name from <idno type="filename">philo_1_1854.xml</idno>

Two comments for the Greek file:

  1. For the long haul we are updating all of the opp URNs for the Greek files to 1st1K, that way we don't have conflict with metadata in the catalog, but that is something I can do at the end when I add updated catalog metadata for all the translations.

  2. We have also started standardizing the metadata in the sections so that it isn't Latin anymore so we would update to: <publisher>Reimer</publisher> <pubPlace>Berlin</pubPlace> but that is also something I'm happy to do in a later pass.

@gregorycrane gregorycrane changed the title (tlg0018-yonge) C D Yonge English translations (tlg0018-yonge2) C D Yonge English translations Jul 26, 2023
@lcerrato
Copy link
Collaborator

Further work needed:

  • make sure Greek is declared as language in header
  • check ref target
  • duplicate notes
  • note tags do not need language or n attribute; should have place and resp
  • breaks around pb's
  • straight apostrophes should be curly
  • quotation marks and block quotes
  • missing paragraphs and indentation notations

@lcerrato
Copy link
Collaborator

@gregorycrane Release date is the date the public sees the work, not the creation date(s) which would be recorded in the change log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants