Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USER REDESIGN: redesign the sidenav for the talawa user portal #1510

Closed
aashimawadhwa opened this issue Jan 28, 2024 · 47 comments · Fixed by #1933
Closed

USER REDESIGN: redesign the sidenav for the talawa user portal #1510

aashimawadhwa opened this issue Jan 28, 2024 · 47 comments · Fixed by #1933
Assignees
Labels
feature request ui/ux issue related and being worked with the figma file of the Admin UI

Comments

@aashimawadhwa
Copy link
Member

aashimawadhwa commented Jan 28, 2024

Is your feature request related to a problem? Please describe.
we are planning redesigning the user portal, this issue is a part of that redesigning.

Describe the solution you'd like
we want to redesign the sidenav for the user portal and follow a theme similar to the talawa admin portal.

Additional context

  1. These are the two side navbars that require modifications.
    Please refer the figma file below :
    https://www.figma.com/file/WksD4uIa5sQJMIk3pR4l0c/Talawa-Design-System-(Official)?type=design&node-id=3447%3A59&mode=design&t=fkgMPaaz67qLwmMz-1
  2. Try to split this up into several smaller PRs, possibly 2-3 screens at a time. This will make the reviewing process much faster.

Screenshots
Screenshot 2024-01-28 at 10 59 53 PM Screenshot 2024-01-28 at 11 00 02 PM

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@github-actions github-actions bot added ui/ux issue related and being worked with the figma file of the Admin UI unapproved labels Jan 28, 2024
@pateldivyesh1323
Copy link
Contributor

I would like to work on this.

@AnshulKahar2729
Copy link
Contributor

Divyesh are you still working on it? I would like to help in it.

@AnshulKahar2729
Copy link
Contributor

@aashimawadhwa let me know if I can contribute to it.

@Cioppolo14
Copy link
Contributor

@AnshulKahar2729 Thank you for your interest! We aim to do only one issue per person as outlined in our CONTRIBUTING.md file. If the currently assigned person, or a mentor feels that it is a big enough issue to be split, then that could be done. This is very important if you are planning on applying for an internship. With shared issues, it is difficult to know the level of contribution of each person.

@pateldivyesh1323
Copy link
Contributor

@palisadoes @aashimawadhwa Where this button will take the user as there I cannot see profile page on user portal?

Screenshot 2024-01-31 221606

@palisadoes
Copy link
Contributor

The profile page edit will be in a subsequent issue. Let it remain.

@pateldivyesh1323
Copy link
Contributor

@palisadoes Can you tell me what is going to happen to this navbar on user portal? because the sidebar and navbar are conflicting with each other.

image

@palisadoes
Copy link
Contributor

@aashimawadhwa @rishav-jha-mech Please respond to this design question

@aashimawadhwa
Copy link
Member Author

So the whole purpose is to stash the top navbar. We will have a sidenavbar which will render all the menu.
@pateldivyesh1323

@pateldivyesh1323
Copy link
Contributor

pateldivyesh1323 commented Feb 3, 2024

@aashimawadhwa Do I have to remove it or some other issue will be raised to remove it?

For now the sidebar looks like this, please take a look so I can move forward with tests.

Talawa.Admin.-.Google.Chrome.2024-02-03.15-01-53.mp4

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Feb 14, 2024
@pateldivyesh1323
Copy link
Contributor

@palisadoes The files were changed due to the Update Documentation commit which happens automatically. The original fix was changing around 35-40 files. Now I will have to manually filter the original PR files and documentation files. It will take some time for me to make another PR.

@palisadoes
Copy link
Contributor

Why did no other PRs have this issue?

I opened a test PR today against the same repo that didn't generate the files

@palisadoes
Copy link
Contributor

This one opened today didn't generate them

@palisadoes
Copy link
Contributor

Similarly this one too

@pateldivyesh1323
Copy link
Contributor

@palisadoes Maybe it is fixed now, but some PR previously had this problem.

@palisadoes
Copy link
Contributor

  1. We were trying to fix the documentation workflow some weeks ago and some of the earlier PRs had the issue
  2. I would submit again but find a way to not include the documentation branches. (If necessary) This may help
    1. https://stackoverflow.com/questions/12481639/remove-file-from-latest-commit

@palisadoes
Copy link
Contributor

  1. I'm sorry about this. It has been troubling to me that so many people were inconvenienced by our efforts to get the documentation workflow working.
  2. We should have used a separate branch for testing rather than develop.
  3. Part of the problem was that some GitHub features we considered only worked on the default branch and the YAML syntax was very sensitive.
  4. We now have a solution that hopefully works for all branches.

Automated documentation is really important for the repositories. It helps all developers when it's current. This was a priority for a small team of our volunteers.

We tried, we failed and we now think we have succeeded.

@palisadoes
Copy link
Contributor

We are tracking this issue with one of our projects, and we'd like to track its progress especially as the GSoC announcement dates draw near.

  1. When you create your PR, please link it back to this project:
    1. https://github.com/orgs/PalisadoesFoundation/projects/27/views/1
  2. The process is simple. It can be found here:
    1. https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#manually-linking-a-pull-request-to-an-issue-using-the-pull-request-sidebar

@palisadoes
Copy link
Contributor

  1. The collapse action is OK
  2. Please create an issue to fix the hard coding. There is an issue for the sidenav already

@karthxk07
Copy link
Contributor

karthxk07 commented Mar 24, 2024

@palisadoes Sir, Most of the work is complete. Here is how it looks. I just need to write the test. I will make the PR ASAP.

Screencast.from.2024-03-24.23-19-01.webm

Following the PR i will create the issue for the layout issue.

@palisadoes
Copy link
Contributor

It's a big improvement. Thanks for the effort. The improvements in the repo have been remarkable in the past 12 months.

@karthxk07
Copy link
Contributor

@palisadoes Sir, It is always a pleasure helping. Hoping to get my proposal for GSOC accepted, so that I can contribute more. 😊

@palisadoes
Copy link
Contributor

palisadoes commented Mar 27, 2024

Look at this issue for guidance. The should be no scroll bar, nor boxes around the cards. There are other things too

If there is any way to reuse components, that would help also.

@palisadoes
Copy link
Contributor

@palisadoes Sir, It is always a pleasure helping. Hoping to get my proposal for GSOC accepted, so that I can contribute more. 😊

I hope for the best with all applicants. Work with the mentors, they are your window into improvement.

@palisadoes
Copy link
Contributor

I was looking over the User portal UI/UX and found the UI/UX not as intuitive as Admin. How is progress on the sidenav?

Admin had a recently merged sidenav issue that should be used for inspiration.

@karthxk07
Copy link
Contributor

@palisadoes Sir, writing tests has been giving problems. I am working on it nevertheless. Also , I will pull the latest pr and reuse the admin sidebar styles on the user sidebar , that should be easy.

@palisadoes
Copy link
Contributor

Good luck with your exams. That comes first. Thanks for the update.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Apr 15, 2024
@Cioppolo14
Copy link
Contributor

@karthxk07 Are you working on this?

@karthxk07
Copy link
Contributor

@Cioppolo14 I surely am working on this. But it might take me time. But In Organization's interest, I think I should give up on this issue, and let someone else take it up. I should not keep it hanging any longer, and let somebody else complete the remaining work fast.

@github-actions github-actions bot removed the no-issue-activity No issue activity label Apr 16, 2024
@pranshugupta54
Copy link
Member

From the previous screen recording, it looks like you've finished working on the design and only writing tests is left. Maybe you can make a PR for the design and we can cover the tests independently (I can work on it).

@palisadoes
Copy link
Contributor

@karthxk07 Please submit a PR and share your repo with others so that others can contribute to get this implemented. We have done this before with positive results.

@karthxk07
Copy link
Contributor

karthxk07 commented Apr 17, 2024

@palisadoes Sorry sir, Due to unfortunate circumstances, my local setup was wiped and i was also not able to push it to the forked repo. I might not be able to make a PR for this one. I am extremely sorry about this. I will be more careful and vigilant about such things in the future.

@palisadoes
Copy link
Contributor

That's unfortunate. I'll unassign you and see whether anyone else is willing to work on it. Thanks for letting us know and pass by again to assist with issues when you have the time.

@disha1202
Copy link
Contributor

Hi
I would like to work on this

@duplixx
Copy link
Member

duplixx commented Apr 17, 2024

@palisadoes I can work on this

@palisadoes palisadoes linked a pull request Apr 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request ui/ux issue related and being worked with the figma file of the Admin UI
Projects
Development

Successfully merging a pull request may close this issue.

9 participants