-
-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USER REDESIGN: redesign the sidenav for the talawa user portal #1510
Comments
I would like to work on this. |
Divyesh are you still working on it? I would like to help in it. |
@aashimawadhwa let me know if I can contribute to it. |
@AnshulKahar2729 Thank you for your interest! We aim to do only one issue per person as outlined in our CONTRIBUTING.md file. If the currently assigned person, or a mentor feels that it is a big enough issue to be split, then that could be done. This is very important if you are planning on applying for an internship. With shared issues, it is difficult to know the level of contribution of each person. |
@palisadoes @aashimawadhwa Where this button will take the user as there I cannot see profile page on user portal? |
The profile page edit will be in a subsequent issue. Let it remain. |
@palisadoes Can you tell me what is going to happen to this navbar on user portal? because the sidebar and navbar are conflicting with each other. |
@aashimawadhwa @rishav-jha-mech Please respond to this design question |
So the whole purpose is to stash the top navbar. We will have a sidenavbar which will render all the menu. |
@aashimawadhwa Do I have to remove it or some other issue will be raised to remove it? For now the sidebar looks like this, please take a look so I can move forward with tests. Talawa.Admin.-.Google.Chrome.2024-02-03.15-01-53.mp4 |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
@palisadoes The files were changed due to the |
Why did no other PRs have this issue? I opened a test PR today against the same repo that didn't generate the files |
This one opened today didn't generate them |
Similarly this one too |
@palisadoes Maybe it is fixed now, but some PR previously had this problem. |
|
Automated documentation is really important for the repositories. It helps all developers when it's current. This was a priority for a small team of our volunteers. We tried, we failed and we now think we have succeeded. |
We are tracking this issue with one of our projects, and we'd like to track its progress especially as the GSoC announcement dates draw near.
|
|
@palisadoes Sir, Most of the work is complete. Here is how it looks. I just need to write the test. I will make the PR ASAP. Screencast.from.2024-03-24.23-19-01.webmFollowing the PR i will create the issue for the layout issue. |
It's a big improvement. Thanks for the effort. The improvements in the repo have been remarkable in the past 12 months. |
@palisadoes Sir, It is always a pleasure helping. Hoping to get my proposal for GSOC accepted, so that I can contribute more. 😊 |
Look at this issue for guidance. The should be no scroll bar, nor boxes around the cards. There are other things too If there is any way to reuse components, that would help also. |
I hope for the best with all applicants. Work with the mentors, they are your window into improvement. |
I was looking over the User portal UI/UX and found the UI/UX not as intuitive as Admin. How is progress on the sidenav? Admin had a recently merged sidenav issue that should be used for inspiration. |
@palisadoes Sir, writing tests has been giving problems. I am working on it nevertheless. Also , I will pull the latest pr and reuse the admin sidebar styles on the user sidebar , that should be easy. |
Good luck with your exams. That comes first. Thanks for the update. |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
@karthxk07 Are you working on this? |
@Cioppolo14 I surely am working on this. But it might take me time. But In Organization's interest, I think I should give up on this issue, and let someone else take it up. I should not keep it hanging any longer, and let somebody else complete the remaining work fast. |
From the previous screen recording, it looks like you've finished working on the design and only writing tests is left. Maybe you can make a PR for the design and we can cover the tests independently (I can work on it). |
@karthxk07 Please submit a PR and share your repo with others so that others can contribute to get this implemented. We have done this before with positive results. |
@palisadoes Sorry sir, Due to unfortunate circumstances, my local setup was wiped and i was also not able to push it to the forked repo. I might not be able to make a PR for this one. I am extremely sorry about this. I will be more careful and vigilant about such things in the future. |
That's unfortunate. I'll unassign you and see whether anyone else is willing to work on it. Thanks for letting us know and pass by again to assist with issues when you have the time. |
Hi |
@palisadoes I can work on this |
Is your feature request related to a problem? Please describe.
we are planning redesigning the user portal, this issue is a part of that redesigning.
Describe the solution you'd like
we want to redesign the sidenav for the user portal and follow a theme similar to the talawa admin portal.
Additional context
Please refer the figma file below :
https://www.figma.com/file/WksD4uIa5sQJMIk3pR4l0c/Talawa-Design-System-(Official)?type=design&node-id=3447%3A59&mode=design&t=fkgMPaaz67qLwmMz-1
Screenshots
Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359
The text was updated successfully, but these errors were encountered: