-
-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USER REDESIGN: Redesign the sidenav for Talawa user portal #1539
USER REDESIGN: Redesign the sidenav for Talawa user portal #1539
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
@pateldivyesh1323 Can you please fix the failing introspection test? We are working on a fix to this issue. |
@Cioppolo14 Is there something to be done from my side? |
We can move forward without it for now. I will assign reviewers. |
@rishav-jha-mech @aashimawadhwa Can you review this PR? |
as now the side navbar is ready please remove the topbar. @pateldivyesh1323 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1539 +/- ##
===========================================
+ Coverage 96.74% 96.79% +0.05%
===========================================
Files 138 139 +1
Lines 3688 3747 +59
Branches 1125 1172 +47
===========================================
+ Hits 3568 3627 +59
Misses 114 114
Partials 6 6 ☔ View full report in Codecov by Sentry. |
@aashimawadhwa I have removed the top navbar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/components/UserPortal/OrgLeftDrawer/OrgLeftDrawer.module.css
The left drawer has same style and classes as the one component we are using in Admin, just the logical part is different, instead of creating new files everywhere for the same component, create a index.css file in src/assets/css/
folder and import it in src/index.tsx
file. Also when you do this, make sure to remove the same from all the left drawer and corresponding screen components.
@rishav-jha-mech I have tried implementing the requested change but it is creating more and more confusion as the styles are slightly different. This is making one part to keep in index.css and other to keep in their respective module.css files. It is getting difficult to track all of them. |
NOTE Read very carefully
This will put your PR at risk of extensive merge conflicts. Do the following IN THIS ORDER:
This will help to reduce the number of existing and future merge conflicts for your PR. |
|
What kind of change does this PR introduce?
Issue Number:
Fixes #1510
Redesign the sidenav of talawa user portal with theme similar to admin portal.
Figma: https://www.figma.com/file/WksD4uIa5sQJMIk3pR4l0c/Talawa-Design-System-(Official)?type=design&node-id=3447%3A59&mode=design&t=fkgMPaaz67qLwmMz-1
Previous sidebar is removed and two sidebars are added:
User:
Organization:
Did you add tests for your changes?
Yes
Snapshots/Videos:
Talawa.Admin.-.Google.Chrome.2024-02-04.18-28-48.mp4
If relevant, did you update the documentation?
No
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes