Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USER REDESIGN: redesign the organization screen for the talawa user portal #1511

Closed
aashimawadhwa opened this issue Jan 28, 2024 · 24 comments
Closed
Assignees
Labels
feature request ui/ux issue related and being worked with the figma file of the Admin UI

Comments

@aashimawadhwa
Copy link
Member

aashimawadhwa commented Jan 28, 2024

Is your feature request related to a problem? Please describe.
we are planning redesigning the user portal, this issue is a part of that redesigning.

Describe the solution you'd like
we want to redesign the organizations screen for the user portal and follow a theme similar to the talawa admin portal.

Screenshots

Related issue : #1510 (sidenavbar is covered in this issue)

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@github-actions github-actions bot added ui/ux issue related and being worked with the figma file of the Admin UI unapproved labels Jan 28, 2024
@disha1202
Copy link
Contributor

Hi,
I would like to work on this

@takshakmudgal
Copy link
Contributor

I'd like to work on this issue.

@aashimawadhwa
Copy link
Member Author

@disha1202 assigned 👍🏼

@palisadoes
Copy link
Contributor

@aashimawadhwa @disha1202

The design will need an update:

  1. In the User portal the user will want to join the organization, not manage it.
  2. The tiles should therefore have some way of indicating whether the user has already joined or not.

@AnshulKahar2729
Copy link
Contributor

I'd like to work on this issue. Any updates?

@Cioppolo14
Copy link
Contributor

@AnshulKahar2729 If the issue has already been assigned, please don't ask to be assigned. We want everyone to get a chance.

@disha1202
Copy link
Contributor

disha1202 commented Jan 31, 2024

Hi @palisadoes @aashimawadhwa

Here's the design for organization screen for user portal
image

Please take a look.

@palisadoes
Copy link
Contributor

  1. This is OK
  2. Submit a PR when ready

@disha1202
Copy link
Contributor

  • This is OK
  • Submit a PR when ready

Sure, I'll create a PR soon.

@palisadoes
Copy link
Contributor

@disha1202

  1. How will you handle the case where a person has requested to join an organization but it hasn't yet been approved? What API modifications would be required for this?

@disha1202
Copy link
Contributor

disha1202 commented Feb 1, 2024

@disha1202

  1. How will you handle the case where a person has requested to join an organization but it hasn't yet been approved? What API modifications would be required for this?

As per my observation,

  1. There are two types of organisations, one which requires the user to register and other one does not. The organisations that does not requires the user to register have the userRegistrationRequired flag defined as False.

  2. For organisations with userRegistrationRequired flag defined as True the user needs to be approved by the ADMIN of the organisations.

  3. When a new user registers they are supposed to select an organization to join, if the organization that the user wants to join requires users to be approved then a request is sent to the ADMIN of the organization.
    If the user does not selects any organization then they are made to join the default organization and a request is sent to the ADMIN of the default organization.

  4. When an admin approves a user the adminApproved flag is set to True and the organisationId is appended to the joinedOrganizations Array.

As shown in the sample users data below
image

Although it will be difficult to manage the state of multiple organisations with a single adminApproved flag.
Instead it should be something similar to

joinedOrganizations: [ { organizationId: '6537904485008f171cf29924', status: 'pending'}, { organizationId: '6537904485008f171cf29924', status: 'approved'}, { organizationId: '6537904485008f171cf29924', status: 'rejected'}]

What do you think about this?
Also please let me know if I am missing something or misunderstood anything.

@palisadoes
Copy link
Contributor

Thanks,

How will you handle the case where the:

  1. approval is pending?
  2. user wants to withdraw their join request?

Does the API support providing the necessary queries and mutations for this?

@palisadoes
Copy link
Contributor

palisadoes commented Feb 2, 2024

Regarding this:

Yes, this will need to be done. The registration process will benefit greatly.

joinedOrganizations: [ 
  { organizationId: '6537904485008f171cf29924', status: 'pending'}, 
  { organizationId: '6537904485008f171cf29924', status: 'approved'}, 
  { organizationId: '6537904485008f171cf29924', status: 'rejected'}
]
  1. You should open an issue in the API describing what you want in detail.
  2. Ask to be assigned if necessary.

@disha1202
Copy link
Contributor

Regarding this:

Yes, this will need to be done. The registration process will benefit greatly.

joinedOrganizations: [ 
  { organizationId: '6537904485008f171cf29924', status: 'pending'}, 
  { organizationId: '6537904485008f171cf29924', status: 'approved'}, 
  { organizationId: '6537904485008f171cf29924', status: 'rejected'}
]
  1. You should open an issue in the API describing what you want in detail.
  2. Ask to be assigned if necessary.

Sure I'll create an issue in Tarawa API and also share the updated designs to handle pending state and option to withdraw request.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Feb 13, 2024
@Cioppolo14
Copy link
Contributor

@disha1202 Are you working on this?

@disha1202
Copy link
Contributor

@disha1202 Are you working on this?

Yes I'm working on it

@github-actions github-actions bot removed the no-issue-activity No issue activity label Feb 14, 2024
@disha1202
Copy link
Contributor

disha1202 commented Feb 16, 2024

Hi
Here is the updated design

@aashimawadhwa @rishav-jha-mech
Please take a look

image

@disha1202
Copy link
Contributor

disha1202 commented Feb 16, 2024

Regarding this:

Yes, this will need to be done. The registration process will benefit greatly.

joinedOrganizations: [ 
  { organizationId: '6537904485008f171cf29924', status: 'pending'}, 
  { organizationId: '6537904485008f171cf29924', status: 'approved'}, 
  { organizationId: '6537904485008f171cf29924', status: 'rejected'}
]
  1. You should open an issue in the API describing what you want in detail.
  2. Ask to be assigned if necessary.

@palisadoes
We might not require this. We already have membershipRequests in user schema which will provide the status of the requests.

And we can completely remove the adminApproved flag.

Also, I came across this comment which states that we have removed support for privateOrganizations.

joinPublicOrganization mutation which throws error if the userRegistrationRequired flag is true does not makes sense.

It should be updated to joinOrganization mutation which which creates a membershipRequest with ACTIVE status if userRegistrationRequired flag is true else works as is.

@palisadoes
Copy link
Contributor

  1. Take a look at this PR. It may answer your questions. If not, create an issue to implement your suggestion.
    1. Sign up route changed with bug fix and proper data importation talawa-api#1770
  2. Yes, adminApproved should be removed

@palisadoes
Copy link
Contributor

  1. My mistake on the PR above.
  2. Yes, please open an issue to fix the expected behavior

@disha1202
Copy link
Contributor

Hi Here is the updated design

@aashimawadhwa @rishav-jha-mech Please take a look

image

@aashimawadhwa @rishav-jha-mech
Any update on this?

@aashimawadhwa
Copy link
Member Author

@Disha can you make buttons like this?

Screenshot 2024-02-28 at 11 45 18 PM

@disha1202
Copy link
Contributor

@Disha can you make buttons like this?

Screenshot 2024-02-28 at 11 45 18 PM

@aashimawadhwa Updated the buttons
Screenshot 2024-03-01 at 2 24 58 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request ui/ux issue related and being worked with the figma file of the Admin UI
Projects
None yet
Development

No branches or pull requests

6 participants