Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: An option for users to leave the Organization #1873

Closed
pranshugupta54 opened this issue Apr 4, 2024 · 35 comments
Closed

Feature: An option for users to leave the Organization #1873

pranshugupta54 opened this issue Apr 4, 2024 · 35 comments
Assignees

Comments

@pranshugupta54
Copy link
Member

Is your feature request related to a problem? Please describe.
There is no way for the user to exit/leave the Organization.

Describe the solution you'd like
An option on the left panel for users to leave the Organization.

Describe alternatives you've considered
Can discuss on design

Approach to be followed (optional)
A clear and concise description of approach to be followed.

Additional context
Add any other context or screenshots about the feature request here.

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@palisadoes
Copy link
Contributor

Will this require an corresponding issue in the API?

@varshith257
Copy link
Member

@palisadoes There is no need for any API work for this. Already sufficient code is present in the API.

@duplixx
Copy link
Member

duplixx commented Apr 5, 2024

do we have any existing UI for this @palisadoes

@pranshugupta54
Copy link
Member Author

  • This is Posts page under User Portal (Most probably the username and Sign Out button from left right will be shifted to top right like we changed in Admin panel to keep it similar)
  • We can put "Leave Org" at the current place of "Sign Out"

We first need to get this left side of users completed in #1510

image

@duplixx
Copy link
Member

duplixx commented Apr 5, 2024

@pranshugupta54 that won't look good and it will be confusing for users

  • This is Posts page under User Portal (Most probably the username and Sign Out button from left right will be shifted to top right like we changed in Admin panel to keep it similar)
  • We can put "Leave Org" at the current place of "Sign Out"

We first need to get this left side of users completed in #1510

image

@duplixx
Copy link
Member

duplixx commented Apr 5, 2024

@pranshugupta54 leaving the organization shouldn't be this accessible. We need to implement a better design to prevent accidental actions.

@pranshugupta54
Copy link
Member Author

We should keep it easy to use, I know we want more user engagement but at the same time we want the platform to be easy to use. For accidentally leaving, we can implement two steps (using confirmation modal)

@duplixx
Copy link
Member

duplixx commented Apr 5, 2024

Yeah, @pranshugupta54, if we're placing the 'leave organization' feature in the sidebar, a two-step process would definitely be more secure.

@chandel-aman
Copy link
Contributor

I think keeping the "leave organization" feature in the sidebar won't be a good idea, as it may encourage users to leave the organization instead of increasing engagement.

  1. We could place it in the user's settings, or,
  2. We could have a separate screen to manage organizations and related activities, as we will be adding notifications for users. There is a GSoC project for Chat and Notifications, as well as for event-related broadcasts for the user from the admin.

@chandel-aman
Copy link
Contributor

As both @pranshugupta54 and @duplixx suggested we should keep it easily accessible with 2-step user flow.
We could take inspiration from Breezechms, where they have hidden the "Cancel Account" option but made it easily accessible.

Screencast.from.05-04-24.11.20.59.PM.IST.webm

@pranshugupta54
Copy link
Member Author

We can use existing designs in Talawa, i think we have similar modal in Delete Org (For superAdmin). We can use that same design directly instead.

@chandel-aman
Copy link
Contributor

@pranshugupta54 Yeah, we could surely do that to maintain design consistency throughout the project.

@duplixx
Copy link
Member

duplixx commented Apr 5, 2024

@chandel-aman yup the conclusion is add 2-step modal for "leave organization" button

@pranshugupta54
Copy link
Member Author

pranshugupta54 commented Apr 5, 2024

I can take this up, I only have one assigned which is waiting for other issues to be resolved first.

We'll need to wait for re-design to complete first

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Apr 16, 2024
@anuragnegi000
Copy link
Contributor

So the final changes would be this?

We can use existing designs in Talawa, i think we have similar modal in Delete Org (For superAdmin). We can use that same design directly instead.

@palisadoes
Copy link
Contributor

So the final changes would be this?

We can use existing designs in Talawa, i think we have similar modal in Delete Org (For superAdmin). We can use that same design directly instead.

  1. There isn't an organization settings option to mimic the admin screen functionality.
  2. You'll need to think of a different approach

@github-actions github-actions bot removed the no-issue-activity No issue activity label Aug 17, 2024
@AnshulKahar2729
Copy link
Contributor

@palisadoes
image
What about having a dropdown menu when you click on the organization name present in the left sidebar, there will be two options in dropdown menu, one will be to leave the organization and the other will be to visit the corresponding page.

This will solve both of our problems, the inconsistency of the design and the less user engagement.

@AnshulKahar2729
Copy link
Contributor

Any discussion on this issue, as this is still not implemented. I want to work on this once the design is decided.

@palisadoes
Copy link
Contributor

There should be the option to deselect the organization on the home screen where users select their organization.

@AnshulKahar2729
Copy link
Contributor

AnshulKahar2729 commented Sep 6, 2024

@palisadoes

"Which UI should we choose?"
Screenshot from 2024-09-02 15-54-30
image

Or we can go with both, even that's okay I think.

@pranshugupta54
Copy link
Member Author

We can allow users to leave the organization both from the "All Orgs" view and from within a specific organization's view.
Additionally, ensure there is a modal pop-up with the message something like:

Are you sure you want to leave the XYZ organization? 

This action cannot be undone. If the organization requires approval, you will not be able to rejoin without it. Any related data or permissions may also be lost.

@gopalepic
Copy link

@palisadoes first of all thankyou to you that this repo is highly active as compare to other orgs , I have gone through the whole issue and would like to work on it , I wanted to implement this Enhancement and merge it , can you assign it to me

@github-actions github-actions bot added the no-issue-activity No issue activity label Nov 26, 2024
@palisadoes
Copy link
Contributor

Unassigning. Inactivity. No PR

@raggettii
Copy link
Contributor

raggettii commented Nov 26, 2024

Can you please assign it to me @palisadoes

@github-actions github-actions bot removed the no-issue-activity No issue activity label Nov 27, 2024
@raggettii
Copy link
Contributor

i have solved the issue but confused how to create PR as i also have made some changes in the talawa-api repo

@palisadoes
Copy link
Contributor

i have solved the issue but confused how to create PR as i also have made some changes in the talawa-api repo

Please refer to this guide:

Also:

  1. Read the CONTRIBUTING.md file in this repo
  2. The slack channels will help.
  3. There are many tutorials on YouTube.

raggettii added a commit to raggettii/talawa-admin that referenced this issue Dec 9, 2024
raggettii added a commit to raggettii/talawa-admin that referenced this issue Dec 9, 2024
raggettii added a commit to raggettii/talawa-admin that referenced this issue Dec 9, 2024
raggettii added a commit to raggettii/talawa-admin that referenced this issue Dec 9, 2024
raggettii added a commit to raggettii/talawa-admin that referenced this issue Dec 14, 2024
raggettii added a commit to raggettii/talawa-admin that referenced this issue Dec 15, 2024
raggettii added a commit to raggettii/talawa-admin that referenced this issue Dec 15, 2024
raggettii added a commit to raggettii/talawa-admin that referenced this issue Dec 15, 2024
raggettii added a commit to raggettii/talawa-admin that referenced this issue Dec 15, 2024
raggettii added a commit to raggettii/talawa-admin that referenced this issue Dec 15, 2024
raggettii added a commit to raggettii/talawa-admin that referenced this issue Dec 21, 2024
raggettii added a commit to raggettii/talawa-admin that referenced this issue Dec 21, 2024
raggettii added a commit to raggettii/talawa-admin that referenced this issue Dec 21, 2024
raggettii added a commit to raggettii/talawa-admin that referenced this issue Dec 22, 2024
palisadoes pushed a commit to PalisadoesFoundation/talawa-api that referenced this issue Dec 23, 2024
palisadoes pushed a commit that referenced this issue Dec 23, 2024
…1873) (#2629)

* Fixed: issue-#1873

* Fixed: issue-#1873

* Fixed: issue-#1873

* Fixed: issue-#1873

* Not title changed to title

* Ensure case-insensitive email verification for leaving organization

* Null check for organization data added

* Refetching of orgs added after leaving org

* GraphQL error scenarios to test cases Added

* GraphQL error scenarios to test cases Added 1

* Downgrade vitest to 2.1.5 to resolve peer dependency conflict

* fixed parsing error 1

* TSDoc comment added in LeaveOrganization.tsx 5

* LeaveOrganization.test.tsx file updated 1

* suggested changes are made

* suggested changes are made 2

* optimizing testing file 1

* optimizing testing file 2

* optimizing testing file 2-a

* Fixed: issue-#1873

* Fixed: issue-#1873

* Fixed: issue-#1873

* Fixed: issue-#1873

* Not title changed to title

* Ensure case-insensitive email verification for leaving organization

* Null check for organization data added

* Refetching of orgs added after leaving org

* GraphQL error scenarios to test cases Added

* GraphQL error scenarios to test cases Added 1

* Downgrade vitest to 2.1.5 to resolve peer dependency conflict

* fixed parsing error 1

* TSDoc comment added in LeaveOrganization.tsx 5

* LeaveOrganization.test.tsx file updated 1

* suggested changes are made

* suggested changes are made 2

* optimizing testing file 1

* optimizing testing file 2

* optimizing testing file 2-a

* suggested changes are made 3

* optimizing test file 3

* optimizing test file 3-a

* optimizing test file 3-b

* optimizing test file 3-c

* optimizing test file 3-d

* optimizing test file 3-e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants