Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling editing an advertisement #1157

Closed
aashimawadhwa opened this issue Dec 7, 2023 · 22 comments
Closed

Enabling editing an advertisement #1157

aashimawadhwa opened this issue Dec 7, 2023 · 22 comments
Assignees
Labels

Comments

@aashimawadhwa
Copy link
Member

Is your feature request related to a problem? Please describe.
We have ensured CRUD operations throughout the talawa( wherever necessary). We require an edit ad modal in the Advertisement section on all the created ads.

Describe the solution you'd like
An editing ad modal on all created ads, ensuring fields similar to create ads modal.

Additional context
NA

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@Vaishali054
Copy link
Contributor

@aashimawadhwa can you assign this to me

@Cioppolo14
Copy link
Contributor

@Vaishali054 I assigned you another issue, so you have reached 2 issues.

Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too.

@ibishal
Copy link

ibishal commented Dec 7, 2023

@Cioppolo14 @aashimawadhwa can you assign me this?

@Vaishali054
Copy link
Contributor

@Cioppolo14 , I unassigned myself from one of the issues(#1136), it needs the issue with the pinned post(#1122) to be resolved in order to write test cases for the same.

@01vishu
Copy link

01vishu commented Dec 7, 2023

@Cioppolo14 and @aashimawadhwa, I am interested in contributing to your project and would like to request to be assigned to the project. I believe I have the necessary skills and expertise to make meaningful contributions to the project.

@noman2002
Copy link
Member

@01vishu @ibishal I am assigning this to @Vaishali054 As she commented first and unassigned another issue which is assigned to her. Please take other open issues.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Dec 19, 2023
@ShatilKhan
Copy link

Please assign me

@Vaishali054
Copy link
Contributor

@ShatilKhan I am already working on this, just waiting for the api to incorporate the feature to update, you can checkout other open issues.

@github-actions github-actions bot removed the no-issue-activity No issue activity label Dec 22, 2023
@Vaishali054 Vaishali054 removed their assignment Dec 23, 2023
@Vaishali054
Copy link
Contributor

@aashimawadhwa This issue has been resolved, could you please close it? Thank you!

@palisadoes
Copy link
Contributor

@Vaishali054

Unfortunately, this PR should not have been merged as we have discovered that:

  1. the tests were faulty and
  2. the the corresponding mutation in the API was not done.

So this feature would not work worked.

  1. If this assessment is true, then please be more professional in your approach to our repositories.
  2. If it is not, then please let us know your view on the matter

@palisadoes
Copy link
Contributor

The fastest solution is to revert the PR. Too many other PRs are dependent on this

@palisadoes
Copy link
Contributor

  1. Reopening so that this can be tackled again.
  2. The original PR can be used as a guide
  3. A corresponding mutation in the API will need to be created beforehand and an issue will need to be created for that by who ever is assigned this new issue

@palisadoes palisadoes reopened this Dec 25, 2023
@aarishshahmohsin
Copy link
Contributor

Can I be assigned this issue?

@Vaishali054
Copy link
Contributor

@palisadoes I should have been more responsible regarding this. @SiddheshKukade was going to add the mutation to the talawaAPI as discussed in the PR comments.

@palisadoes
Copy link
Contributor

@Vaishali054

  1. We all make mistakes.
  2. I'll reassign this to you. Please fix it.

@Vaishali054
Copy link
Contributor

Thank you for the confidence @palisadoes.

@palisadoes
Copy link
Contributor

  1. The faster we recognize failure, seek assistance and escalate, the better it is for the community on the whole.
  2. Only better collaboration will improve Talawa.

Copy link

github-actions bot commented Jan 5, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jan 5, 2024
@palisadoes
Copy link
Contributor

@Vaishali054 Are you still working on this?

@Vaishali054
Copy link
Contributor

We are fine tuning the backend part of this PR. I have made a PR for it. Once that is merged then I will update the PR for this issue with latest changes otherwise it won't pass the checks

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants