-
-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the Filtering Functionality #1281
Added the Filtering Functionality #1281
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Please fix the failing tests |
These tests are failing for all the past few PRs. There must be some error in the main branch. |
It's related to this issue. We are trying to resolve it quickly |
The offending PR has been reverted. Please merge with the latest upstream |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1281 +/- ##
===========================================
+ Coverage 96.23% 96.30% +0.06%
===========================================
Files 137 137
Lines 3344 3379 +35
Branches 939 945 +6
===========================================
+ Hits 3218 3254 +36
+ Misses 120 119 -1
Partials 6 6 ☔ View full report in Codecov by Sentry. |
@aarishshahmohsin can you fix the failing test @aarishshahmohsin |
I have fixed them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
This reverts commit f1c4e3e.
What kind of change does this PR introduce?
this PR adds the filtering functionality in the Users Component.
Issue Number:
Fixes #1196
Did you add tests for your changes?
No
Snapshots/Videos:
www_screencapture_com_2023-12-25_15_59.webm
If relevant, did you update the documentation?
Summary
I have added the filter functionality that was missing from the user component
Does this PR introduce a breaking change?
No
Other information
I think more can be added, because I saw somethings missing. Should I make an issue? Please also tell if I have to make tests for this PR.
Have you read the contributing guide?
Yes