Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the Filtering Functionality #1281

Merged
merged 9 commits into from
Dec 27, 2023

Conversation

aarishshahmohsin
Copy link
Contributor

What kind of change does this PR introduce?

this PR adds the filtering functionality in the Users Component.

Issue Number:

Fixes #1196

Did you add tests for your changes?

No

Snapshots/Videos:
www_screencapture_com_2023-12-25_15_59.webm

If relevant, did you update the documentation?

Summary

I have added the filter functionality that was missing from the user component

Does this PR introduce a breaking change?

No

Other information
I think more can be added, because I saw somethings missing. Should I make an issue? Please also tell if I have to make tests for this PR.

Have you read the contributing guide?

Yes

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@palisadoes
Copy link
Contributor

Please fix the failing tests

@aarishshahmohsin
Copy link
Contributor Author

These tests are failing for all the past few PRs. There must be some error in the main branch.

@palisadoes
Copy link
Contributor

palisadoes commented Dec 25, 2023

It's related to this issue. We are trying to resolve it quickly

@palisadoes
Copy link
Contributor

The offending PR has been reverted. Please merge with the latest upstream

Copy link

codecov bot commented Dec 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e9e341) 96.23% compared to head (04acf86) 96.30%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1281      +/-   ##
===========================================
+ Coverage    96.23%   96.30%   +0.06%     
===========================================
  Files          137      137              
  Lines         3344     3379      +35     
  Branches       939      945       +6     
===========================================
+ Hits          3218     3254      +36     
+ Misses         120      119       -1     
  Partials         6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aashimawadhwa
Copy link
Member

@aarishshahmohsin can you fix the failing test @aarishshahmohsin

@aarishshahmohsin
Copy link
Contributor Author

@aarishshahmohsin can you fix the failing test @aarishshahmohsin

I have fixed them.

Copy link
Member

@aashimawadhwa aashimawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@palisadoes palisadoes merged commit f1c4e3e into PalisadoesFoundation:develop Dec 27, 2023
8 checks passed
VaibhavTalkhande added a commit to VaibhavTalkhande/talawa-admin that referenced this pull request Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants