Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed unused dependencies and devDependencies #1268

Closed
wants to merge 6 commits into from

Conversation

Veer0x1
Copy link
Contributor

@Veer0x1 Veer0x1 commented Dec 23, 2023

What kind of change does this PR introduce?
Removed unused dependencies

Issue Number:

Fixes #1254

Did you add tests for your changes?
NA

Snapshots/Videos:

If relevant, did you update the documentation?

Summary
Successfully removed unused dependencies, ran the test, and build, everything is working fine.

Does this PR introduce a breaking change?

Other information

Have you read the contributing guide?
Yes

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.

@palisadoes
Copy link
Contributor

Please fix the failing tests

@Veer0x1
Copy link
Contributor Author

Veer0x1 commented Dec 24, 2023

I have added the missing package postcss-module and have three failing tests because those tests were not written correctly and merged here(269a3f0) and also the graphql introspection is failing cause we don't have UpdateAdvertisment mutation in API repo, should I create a different PR to fix those test ? And should I add the new UpdateAdvertisment mutation in API repo?
Screenshot 2023-12-24 at 1 53 50 PM

@Cioppolo14
Copy link
Contributor

@noman2002 @palisadoes Could one of you weigh in on how to proceed?

@palisadoes
Copy link
Contributor

@Veer0x1

  1. Please fix the tests in this PR
  2. Yes open an issue to fix the introspection in Talawa-API.

Thanks for pointing this out. We can now be more vigilant about the introspection check.

@palisadoes
Copy link
Contributor

I've also requested clarification here:

@palisadoes
Copy link
Contributor

@Veer0x1 Better yet, ask to be assigned to this issue and fix the tests properly as a separate PR

@palisadoes
Copy link
Contributor

This is affecting this PR too

@palisadoes
Copy link
Contributor

The offending PR has been reverted. Please merge with the latest upstream

@Veer0x1
Copy link
Contributor Author

Veer0x1 commented Dec 25, 2023

The offending PR has been reverted. Please merge with the latest upstream

sure

@Veer0x1
Copy link
Contributor Author

Veer0x1 commented Dec 25, 2023

@Veer0x1 Better yet, ask to be assigned to this issue and fix the tests properly as a separate PR

You have assigned it to vaishali, Let me open a issue in API repo to add the graphql types there so that introspection don't fail

@palisadoes
Copy link
Contributor

@Veer0x1 Better yet, ask to be assigned to this issue and fix the tests properly as a separate PR

You have assigned it to vaishali, Let me open a issue in API repo to add the graphql types there so that introspection don't fail

No need. That issue was already created by vaishali

@Veer0x1
Copy link
Contributor Author

Veer0x1 commented Dec 26, 2023

@Veer0x1 Better yet, ask to be assigned to this issue and fix the tests properly as a separate PR

You have assigned it to vaishali, Let me open a issue in API repo to add the graphql types there so that introspection don't fail

No need. That issue was already created by vaishali

will this PR merged when Vaishali fixes those test?

@palisadoes
Copy link
Contributor

We reverted the PR. Update with your upstream. The errors should go away

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dfe1dc9) 96.24% compared to head (50ec5d2) 96.24%.
Report is 13 commits behind head on develop.

❗ Current head 50ec5d2 differs from pull request most recent head ce93e81. Consider uploading reports for the commit ce93e81 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1268   +/-   ##
========================================
  Coverage    96.24%   96.24%           
========================================
  Files          137      137           
  Lines         3353     3353           
  Branches       942      942           
========================================
  Hits          3227     3227           
  Misses         120      120           
  Partials         6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Veer0x1
Copy link
Contributor Author

Veer0x1 commented Dec 27, 2023

@palisadoes I have fetched the latest changes from upstream

@Veer0x1
Copy link
Contributor Author

Veer0x1 commented Dec 28, 2023

@noman2002 @beingnoble03 please review this PR.

@noman2002
Copy link
Member

@Veer0x1 Please fix the conflicting files.

@Veer0x1
Copy link
Contributor Author

Veer0x1 commented Jan 1, 2024

@noman2002 there were to many conflicts, so I'm creating a fresh new PR which is in sync with develop branch.

@Veer0x1 Veer0x1 closed this Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants