-
-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed unused dependencies and devDependencies #1268
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
Please fix the failing tests |
I have added the missing package |
@noman2002 @palisadoes Could one of you weigh in on how to proceed? |
Thanks for pointing this out. We can now be more vigilant about the introspection check. |
I've also requested clarification here: |
@Veer0x1 Better yet, ask to be assigned to this issue and fix the tests properly as a separate PR |
This is affecting this PR too |
The offending PR has been reverted. Please merge with the latest upstream |
sure |
You have assigned it to vaishali, Let me open a issue in API repo to add the graphql types there so that introspection don't fail |
No need. That issue was already created by vaishali |
will this PR merged when Vaishali fixes those test? |
We reverted the PR. Update with your upstream. The errors should go away |
89a9365
to
d4f9a79
Compare
d4f9a79
to
9ecdb6c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1268 +/- ##
========================================
Coverage 96.24% 96.24%
========================================
Files 137 137
Lines 3353 3353
Branches 942 942
========================================
Hits 3227 3227
Misses 120 120
Partials 6 6 ☔ View full report in Codecov by Sentry. |
@palisadoes I have fetched the latest changes from upstream |
@noman2002 @beingnoble03 please review this PR. |
@Veer0x1 Please fix the conflicting files. |
@noman2002 there were to many conflicts, so I'm creating a fresh new PR which is in sync with develop branch. |
What kind of change does this PR introduce?
Removed unused dependencies
Issue Number:
Fixes #1254
Did you add tests for your changes?
NA
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Successfully removed unused dependencies, ran the test, and build, everything is working fine.
Does this PR introduce a breaking change?
Other information
Have you read the contributing guide?
Yes