Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling editing an advertisement #1428

Merged
merged 23 commits into from
Jan 18, 2024

Conversation

Vaishali054
Copy link
Contributor

@Vaishali054 Vaishali054 commented Jan 14, 2024

What kind of change does this PR introduce?

Enabling editing an advertisement

Issue Number:

Closes #1157

Did you add tests for your changes?

Yes

Snapshots/Videos:

Untitled.video.-.Made.with.Clipchamp.2.mp4

Advertisement Type Dropdown

Screenshot 2024-01-15 143054

Date selector

Screenshot 2024-01-15 143124

If relevant, did you update the documentation?

NA

Summary

Adding edit advertisement modal

Does this PR introduce a breaking change?

No

Have you read the contributing guide?

Yes

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (16de771) 97.34% compared to head (9be5d34) 97.39%.
Report is 9 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1428      +/-   ##
===========================================
+ Coverage    97.34%   97.39%   +0.04%     
===========================================
  Files          136      143       +7     
  Lines         3572     3640      +68     
  Branches      1039     1073      +34     
===========================================
+ Hits          3477     3545      +68     
  Misses          90       90              
  Partials         5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palisadoes
Copy link
Contributor

  1. Please fix the introspection tests.
  2. Update any items that may not have been a part of this PR. We merged a previous one without checking sufficiently

@beingnoble03
Copy link
Member

@Vaishali054 the dropdown isn't visible in the added video recording. Can you please attach a screenshot of the dropdown or update the video?

@Vaishali054
Copy link
Contributor Author

@beingnoble03 added the snapshots of the dropdowns. Please check.

@beingnoble03
Copy link
Member

Also fix the failing tests

@Vaishali054
Copy link
Contributor Author

Vaishali054 commented Jan 15, 2024

@beingnoble03 It is due to a bug found in one of the workflows. The issue #1429 will fix this. I will add a commit to trigger re-run of the workflows once this issue is resolved.

Copy link
Member

@beingnoble03 beingnoble03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vaishali054 please address the comments.

@Vaishali054
Copy link
Contributor Author

@beingnoble03 updated the codebase with said changes

Copy link
Member

@beingnoble03 beingnoble03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Thanks @Vaishali054!

@palisadoes palisadoes merged commit c627166 into PalisadoesFoundation:develop Jan 18, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants