-
-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling editing an advertisement #1428
Enabling editing an advertisement #1428
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1428 +/- ##
===========================================
+ Coverage 97.34% 97.39% +0.04%
===========================================
Files 136 143 +7
Lines 3572 3640 +68
Branches 1039 1073 +34
===========================================
+ Hits 3477 3545 +68
Misses 90 90
Partials 5 5 ☔ View full report in Codecov by Sentry. |
|
@Vaishali054 the dropdown isn't visible in the added video recording. Can you please attach a screenshot of the dropdown or update the video? |
@beingnoble03 added the snapshots of the dropdowns. Please check. |
Also fix the failing tests |
@beingnoble03 It is due to a bug found in one of the workflows. The issue #1429 will fix this. I will add a commit to trigger re-run of the workflows once this issue is resolved. |
src/components/Advertisements/core/AdvertisementEntry/AdvertisementEntry.tsx
Show resolved
Hide resolved
src/components/Advertisements/core/AdvertisementRegister/AdvertisementRegister.tsx
Outdated
Show resolved
Hide resolved
src/components/Advertisements/core/AdvertisementEntry/AdvertisementEntry.test.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vaishali054 please address the comments.
@beingnoble03 updated the codebase with said changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Thanks @Vaishali054!
c627166
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
Enabling editing an advertisement
Issue Number:
Closes #1157
Did you add tests for your changes?
Yes
Snapshots/Videos:
Untitled.video.-.Made.with.Clipchamp.2.mp4
Advertisement Type Dropdown
Date selector
If relevant, did you update the documentation?
NA
Summary
Adding edit advertisement modal
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes