Update mod to release-20230225 #222
Conversation
Updated suggested VSCode extensions, added a launch profile and a task for running the Utility.
Plus additionally backported OpenRA ModSDK PR 185.
In order to match the engine project files and target framework/engine version.
penev92
force-pushed
the
updateModTo20230225
branch
from
f6d60a4 to
0213c5a
Compare
|
Added a bunch of fixes, updates and polish. This should now be good to go. |
- Changed D2.dll assembly location - Added VideoFormats and TerrainFormats (OpenRA PRs 18728 and 18773) - Updated GameSpeeds definitions (OpenRA PR 19297) - Added ingame-observer.yaml (The common one was removed in OpenRA PR 20436, so we need to add our own copy of it.) - Added references to new common chrome layout files (settings, chat, notifications, etc.) OpenRA PRs: 18948, 19458, 19460, 19461 - Updated translation setup (OpenRA PRs 18959 and 19847) - Added DefaultOrderGenerator (OpenRA PR 19504) - Removed invalid ColorValidator node (??)
The utility didn't add the ControlGroups trait because that is added based on the Selection trait and d2 uses its own D2Selection trait. Courtesy of OpenRA PR 19666.
The tileset should reference a palette reference, not a file name.
The utility removed the ResourceType definitions but didn't add the new ResourceLayer, ResourceRenderer and EditorResourceRenderer configurations. Courtesy of OpenRA PR 19090.
OpenRA PR 19335.
Copied checkbox tick and cross definitions from D2k.
Based on OpenRA PR 18846.
OpenRA PR 18434.
Addressed the code style rule violations that `make check` would error on.
These were all things that produce warnings or errors from the linter. Some of them have not been updated in years, some are as old as the git history in this repository.
penev92
force-pushed
the
updateModTo20230225
branch
from
0213c5a to
48a0b10
Compare
|
Ok, apparently I was wrong - this was not ready. Both |
|
@evgeniysergeev are you able to review? I'm most interested in some things from commit |
Sorry for late answer. I'm trying to review now. |
mainmenu-prompts.yaml was commented in d2 mod. But it is used in latest versions of OpenRA and need to be uncommented again. This is also needed for PR #222 (Update mod to release-20230225)
There was a problem hiding this comment.
BuildableTerrainOverlay is replaced with https://github.com/OpenRA/d2/blob/master/OpenRA.Mods.D2/Graphics/D2BuildingPlacementRenderable.cs
Is concfoot.shp
it still used somewhere?
There was a problem hiding this comment.
After the update, spice ends very quickly on maps. In the original game it ends not so fast.
|
@penev92 , I think this is great PR. All this comments above can be fixed later, and changes can be merged. But if you have a time, can you take a look at comments? |
There was a problem hiding this comment.
Pips were not used in the original game. Is it important to add them in the update?
Issue #148 was created to remove pips.
There was a problem hiding this comment.
Maybe also replace
~^SupportDir|maps/d2/release-20210321: User
with
~^SupportDir|maps/d2/release-20230225: User ?
Don't know what should happen when Devastator is overloaded. Is this overloading exists in original game? :-) |
It is finally time to update the mod to OpenRA's release
20230225.To make this as simple as possible for everyone involved I tried to follow the commit structure and all the ideas behind OpenRA/ra2#806.
This is still WIP, but I'm opening it so hopefully the reviewing process can gradually get going and also so someone else doesn't waste effort doing the same work at the same time.
Supersedes #201.
Closes #212.