[New Check]: Check timestamps ascending with nans #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
for more information, see https://pre-commit.ci
…nans' into check_timestamps_ascending_with_nans
bendichter
reviewed
Jul 30, 2024
|
@alessandratrapani this looks great! Can you also please add a section in the best practices document? |
Co-authored-by: Cody Baker <[email protected]>
…nans' into check_timestamps_ascending_with_nans
CodyCBakerPhD
approved these changes
Aug 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #480 +/- ##
==========================================
+ Coverage 87.07% 87.14% +0.07%
==========================================
Files 23 23
Lines 1253 1260 +7
==========================================
+ Hits 1091 1098 +7
Misses 162 162
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #476