Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: check_timestamps_ascending is triggered when timestamps have NaNs #476

Closed
3 tasks done
bendichter opened this issue Jun 23, 2024 · 0 comments · Fixed by #480
Closed
3 tasks done

[Bug]: check_timestamps_ascending is triggered when timestamps have NaNs #476

bendichter opened this issue Jun 23, 2024 · 0 comments · Fixed by #480
Assignees
Labels
category: bug errors in the code or code behavior

Comments

@bendichter
Copy link
Contributor

What happened?

I am doing the Reimer Lab conversion and we have a timestamps array that contains NaNs. I just decided to leave them in. Then when running the inspector, this triggers the check_timestamps_ascending check, even though all the non-NaN values are ascending. I think the timestamps array should be flagged by the inspector, but this should be its own check, and if the defined values are ascending it should not trigger the check_timestamps_ascending check.

Operating System

macOS

Python Version

3.9

Were you streaming with ROS3?

No

Package Versions

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • Have you ensured this bug was not already reported?
  • To the best of your ability, have you ensured this is a bug within the code that checks the NWBFile, rather than a bug in the NWBFile reader (e.g., PyNWB or MatNWB)?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug errors in the code or code behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants