Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-update workflow #786

Merged
merged 27 commits into from
May 29, 2024
Merged

Add auto-update workflow #786

merged 27 commits into from
May 29, 2024

Conversation

garrettmflynn
Copy link
Member

This PR implements a user-driven update workflow for the GUIDE that notifies users of a new release on the Settings page. This should only show if a new release is actually present compared to the current version.
Screenshot 2024-05-20 at 11 52 16 AM

Clicking the info icon will display a record of the release notes.
Screenshot 2024-05-20 at 1 12 39 PM

The Update button then triggers the electron-updater package to download the latest release (with a related progress bar) and asks the user if they'd like to restart the application now (activating the downloaded release) or defer this until a manual close.

To test, I'd suggest that you create a local build and go through this workflow. The success of this process on Mac depends on proper code-signing, but I believe you should be able to complete this on a Windows PC.

@garrettmflynn garrettmflynn requested a review from rly May 20, 2024 22:47
@garrettmflynn garrettmflynn linked an issue May 20, 2024 that may be closed by this pull request
@CodyCBakerPhD
Copy link
Collaborator

I can take a crack at rebasing this after the next 2 frontend refactors are done

@garrettmflynn the next one was the separation of frontend tests and stories from other assets/pages, correct?

@garrettmflynn
Copy link
Member Author

Yep! I'll make the final changes noted yesterday after that's merged

@CodyCBakerPhD
Copy link
Collaborator

OK this PR is rebased; however, it always looks as if it triggered some problem in the Windows test (perhaps that same you alluded to about modals popping up and closing?)

@CodyCBakerPhD
Copy link
Collaborator

Worked great on Windows!

@CodyCBakerPhD CodyCBakerPhD enabled auto-merge May 29, 2024 20:53
@CodyCBakerPhD CodyCBakerPhD disabled auto-merge May 29, 2024 21:00
@garrettmflynn
Copy link
Member Author

Worked great on Windows!

Where did it do this? I have no idea what's going on here 😅

@CodyCBakerPhD CodyCBakerPhD enabled auto-merge May 29, 2024 22:46
@CodyCBakerPhD
Copy link
Collaborator

Where did it do this? I have no idea what's going on here 😅

I mean the full build and distributable on Windows; it showed the auto-update thing in settings and it all looked perfect; auto-updating installed the current released version in the previous installation directory

@garrettmflynn
Copy link
Member Author

Ah awesome!

@CodyCBakerPhD CodyCBakerPhD merged commit 84327e0 into main May 29, 2024
20 of 21 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the autoupdate branch May 29, 2024 22:52
This was referenced May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Auto-Update Workflow
2 participants