Restore windows CI #816
Merged
Restore windows CI #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 30, 2024
|
Fixed the Pipelines test on Windows! Was making this too complicated by adding an As for the DevTests failure, I'm still not sure what's going on there... |
|
Incredible - admirable persistence on this issue! What do you think about disabling dev tests for Windows on this PR and continuing debugging for that on yet another follow-up? |
CodyCBakerPhD
commented
May 30, 2024
Comment on lines
+102
to
+103
| env: | ||
| GIN_DATA_DIRECTORY: ${{ github.workspace }} |
There was a problem hiding this comment.
Ohhh, I had no idea these were (or could be) scoped per line under run/steps
|
Sure sounds good to me. |
|
Cool - this PR technically needs your approval since I'm the one who opened it yesterday 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restoring the previous state of attempting to fix Windows pipelines
There also seems to be a new failure in the Windows DevTests suite (but never BuildTests) following merge of #786
At time of merge it was only seen in the LiveServices tests (and thus disregarded as an impersistent live service specific problem) and not in the dev tests; but it's been seen in the DevTests for Windows ever since as well