Added Symfony translation component

[Vainonen]

Reasons for creating this PR

Link to relevant issue(s), if any

• Closes Upgrade Skosmos to a new translation component #1247

Description of the changes in this PR

• This draft PR is based on @joelit 's First version with a new translation component #1443. Symfony translation component is used for twig translations and also twig-gettext-extractor used in Skosmos 2 is replaced.

Known problems or uncertainties in this PR

• Symfony Translator service is given only one locale in constructor. Translator object is now created for every language. It seems to be possible to set and download locales afterwards to same Translator, so translation could be done more effectively.

Checklist

• phpUnit tests pass locally with my changes
• I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
• The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
• The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

[osma]

CI tests are failing due to minor PHP code style violations. You should correct these, e.g. by running php-cs-fixer. See here for details: https://github.com/NatLibFi/Skosmos/blob/skosmos-3/CONTRIBUTING.md#code-style

[osma]

Now that the gettext function is no longer used in PHP code, could you drop gettext from the list of PHP extensions installed for running the tests under GitHub Actions? I.e. the gettext part should be dropped from these two lines:

Skosmos/.github/workflows/ci.yml

Line 51 in f74bc3c

php_extensions: gettext intl xsl pcov

Skosmos/.github/workflows/ci.yml

Line 60 in f74bc3c

php_extensions: gettext intl xsl pcov

This should ensure that there are no more remaining uses of gettext functions in the PHP code base, at least for the part of the code that is covered by PHPUnit tests.

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
18 Code Smells

No Coverage information
0.0% Duplication

[codecov]

Codecov Report

Patch coverage: 70.58% and project coverage change: +6.16% 🎉

Comparison is base (f63e5fb) 63.89% compared to head (fff56d0) 70.05%.
Report is 40 commits behind head on skosmos-3.

Additional details and impacted files

@@               Coverage Diff               @@
##             skosmos-3    #1466      +/-   ##
===============================================
+ Coverage        63.89%   70.05%   +6.16%     
- Complexity        1634     1641       +7     
===============================================
  Files               32       32              
  Lines             4290     4301      +11     
===============================================
+ Hits              2741     3013     +272     
+ Misses            1549     1288     -261     

Files Changed	Coverage Δ
src/controller/WebController.php	20.38% <30.00%> (+0.51%)	⬆️
src/controller/RestController.php	22.66% <36.36%> (+6.28%)	⬆️
src/model/Vocabulary.php	85.71% <50.00%> (ø)
src/model/ConceptPropertyValue.php	86.58% <66.66%> (+18.29%)	⬆️
src/model/Concept.php	83.49% <83.33%> (+6.65%)	⬆️
src/model/Model.php	81.53% <93.75%> (+1.53%)	⬆️
src/controller/Controller.php	54.62% <100.00%> (-2.75%)	⬇️
src/model/BaseConfig.php	66.66% <100.00%> (-4.77%)	⬇️
src/model/ConceptMappingPropertyValue.php	84.87% <100.00%> (+66.38%)	⬆️
src/model/ConceptProperty.php	96.61% <100.00%> (+6.95%)	⬆️
... and 3 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Vainonen]

Environment variables LANGUAGE and LC_ALL are no longer used, but are still set in dockerfile. Setting locale and languages were removed (the lines below) from tests and did not cause tests to fail:

putenv("LANGUAGE=en_GB.utf8");
putenv("LC_ALL=en_GB.utf8");
setlocale(LC_ALL, 'en_GB.utf8');
bindtextdomain('skosmos', 'resource/translations');
bind_textdomain_codeset('skosmos', 'UTF-8');
textdomain('skosmos');

[osma]

Looks good in general. I gave a few comments:

1. I don't think the Controller should have its own translator, it should use the one in the Model instead
2. Some tests were marked as skipped in this PR and others have been skipped earlier because gettext translations didn't work. Those skips should now be removed if possible.
3. A few minor style issues (mainly commented out lines that should be removed instead)

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
20 Code Smells

No Coverage information
0.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[osma]

I fixed a fragile test in a commit. Now I think this is good enough for merging!

There are still many strings in Twig templates that need to be translated using the new syntax, but I think those are best done in follow-up PRs.

[Vainonen]

Thank you for review @osma