Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First version with a new translation component #1443

Closed
wants to merge 1 commit into from

Conversation

joelit
Copy link
Contributor

@joelit joelit commented Apr 27, 2023

Reasons for creating this PR

Link to relevant issue(s), if any

Description of the changes in this PR

  • Implementation of a new 'trans' filter for twig sing symfony/twig-bundle and symfony/translation
  • Getting rid of the old twig-gettext-extractor
  • Getting rid of the .mo files

Known problems or uncertainties in this PR

  • Composer.json might have unnecessary dependencies
  • Translation component should get the language parameter
  • Unit tests need rewriting / getting rid of the old set-up

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@joelit joelit added this to the 3.0 milestone Apr 27, 2023
@Vainonen Vainonen closed this Aug 17, 2023
@Vainonen
Copy link
Contributor

This draft PR is continued in another PR #1466.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR)
Development

Successfully merging this pull request may close these issues.

2 participants