Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix implementation of ConceptPropertyValue.getLang + add test #1507

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

osma
Copy link
Member

@osma osma commented Aug 31, 2023

Reasons for creating this PR

PR #1466 introduced a bug that causes infinite recursion in ConceptPropertyValue.getLang. This PR fixes the bug and adds a test that exercises the method.

Link to relevant issue(s), if any

Description of the changes in this PR

  • implement getLang by calling the corresponding Model
  • add unit test

Known problems or uncertainties in this PR

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added the bug label Aug 31, 2023
@osma osma added this to the 3.0 milestone Aug 31, 2023
@osma osma self-assigned this Aug 31, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04% 🎉

Comparison is base (76def2f) 70.05% compared to head (c9be91b) 70.09%.

Additional details and impacted files
@@               Coverage Diff               @@
##             skosmos-3    #1507      +/-   ##
===============================================
+ Coverage        70.05%   70.09%   +0.04%     
  Complexity        1641     1641              
===============================================
  Files               32       32              
  Lines             4301     4301              
===============================================
+ Hits              3013     3015       +2     
+ Misses            1288     1286       -2     
Files Changed Coverage Δ
src/model/ConceptPropertyValue.php 89.02% <100.00%> (+2.43%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@osma osma merged commit 0188425 into skosmos-3 Aug 31, 2023
7 of 10 checks passed
@osma osma deleted the fix-conceptpropertyvalue-getlang branch August 31, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR)
Development

Successfully merging this pull request may close these issues.

1 participant