-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set role="application"
#467
Conversation
@prushforth as you noticed popups are no longer announced, which is caused by this PR. If we revert this and apply #466 instead the content is announced. I think it's strange to give featuregroups Either way, we're just working around the root issue. |
Huh I thought we were making progress, and we might be able to tweak something to get the popups read. All your changes seem to have worked, and as far as I recall, popups weren't being read even with limiting the role="application" to the featuregroup. |
Yes we make progress in certain areas and introduce issues in others... Setting
But as noted popups are now not announced, I can confirm they were announced before applying
Yes... #274 (comment):
I've tested setting |
Set
role="application"
on the map element.Close #274, Close #423, Close #466.
Ideally
role="region"
on the Leaflet container would simply have been replaced byrole="application"
, however doing so results in not being announced by NVDA.I've tested numerous combinations, e.g. moving both
aria-label
androle
to the map element, or only settingrole
on the map element andaria-label
and/oraria-roledescription
on the Leaflet container, and vice-versa, etc. This approach seems to be the most consistent one.