Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve controls in popups #468

Merged
merged 2 commits into from
May 19, 2021
Merged

Improve controls in popups #468

merged 2 commits into from
May 19, 2021

Conversation

Malvoz
Copy link
Member

@Malvoz Malvoz commented May 18, 2021

Fixes the following item in #247 (comment):

Also replaces the <div> container for mapml-focus-buttons with <nav>.

Comparison

Before

After

@Malvoz Malvoz requested a review from prushforth May 18, 2021 16:24
@Malvoz
Copy link
Member Author

Malvoz commented May 18, 2021

Also comitted 9612783 to set role="dialog" on popups (does not entirely fix but is one step of #354) to improve the UX for screen reader users.

@prushforth
Copy link
Member

I notice that the content of the popup is not read by NVDA. But it's starting to work better I think. Thanks for this!

@prushforth prushforth merged commit f105f10 into Maps4HTML:master May 19, 2021
@Malvoz Malvoz deleted the improve-popup-controls branch May 19, 2021 15:02
@Malvoz
Copy link
Member Author

Malvoz commented May 19, 2021

I notice that the content of the popup is not read by NVDA.

That is caused by #467...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants