Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set inner role="document" in popups #470

Merged
merged 2 commits into from
May 19, 2021
Merged

Set inner role="document" in popups #470

merged 2 commits into from
May 19, 2021

Conversation

Malvoz
Copy link
Member

@Malvoz Malvoz commented May 19, 2021

Fixes issue with popups not being announced after #467.

Edit: To clarify, role="document" is used to escape the role="application"s behavior.

@Malvoz Malvoz requested a review from prushforth May 19, 2021 17:26
@prushforth
Copy link
Member

This works well, as far as I can tell. I noticed in ff the first restaurant was announced as a diagram. Anyway, it looks reasonable from what I can see. I wonder if there's an automated testing framework for NVDA/JAWS etc.

@prushforth prushforth merged commit 12399ba into Maps4HTML:master May 19, 2021
@Malvoz
Copy link
Member Author

Malvoz commented May 19, 2021

I noticed in ff the first restaurant was announced as a diagram.

That is an issue separate from any of the latest changes. Chrome announce markers as graphic, this is because markers are SVG <g> elements with no explicit role set.

We've discussed markers' roles before and I thought they should be role="button", perhaps with aria-roledescription="feature" (in which case aria-expanded="false" is correctly exposed, and announced as collapsed).

@Malvoz Malvoz deleted the popup-inner-role-document branch May 19, 2021 20:53
@Malvoz
Copy link
Member Author

Malvoz commented May 19, 2021

I wonder if there's an automated testing framework for NVDA/JAWS etc.

axe-core (which has contributors from ARIA spec editors) powers the accessibility tests in Lighthouse and Webhint. But there's a limit to what automated tests can find, so manual testing for WCAG compliance is a must.

@Malvoz Malvoz mentioned this pull request May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants