Chore/Issue#449 - AWS terraform provider version updated for VPC module and GH workflow update #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sekka1 it seems I can't request review from you but mentioning you here so you're aware of it. Cheers! |
yiskaneto
changed the title
yiskaneto
changed the title
yiskaneto
changed the title
yiskaneto
changed the title
yiskaneto
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This resolves issue #449
Changes:
AWS terraform provider version updated for VPC module
With the retirement of EC2-Classic the
enable_classiclinkandenable_classiclink_dns_supportattributes have been removed https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.0.0 hence while trying to use the vpc module with the current configured provider version I get the following error:An argument named "enable_classiclink" is not expected here.Solution: Upgrade the terraform-aws-modules/vpc/aws version to
5.4.0(latest version atm) along with the latest version of the aws terraform provider which atm is5.31.0The
terraform-pipeline-staging.yamlwas updated so it can properly add the comments to the opened PR