Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/Issue#449 - AWS terraform provider version updated for VPC module and GH workflow update #453

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/terraform-pipeline-staging.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ on:
paths:
- 'terraform-environments/aws/staging/**'

permissions:
contents: read
pull-requests: write

jobs:
## This generates a matrix of changed directory to run Terraform on
generate_matrix:
Expand All @@ -27,7 +31,7 @@ jobs:
matrix: ${{ steps.set-matrix.outputs.matrix }}
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
fetch-depth: 2

Expand Down
2 changes: 1 addition & 1 deletion terraform-environments/aws/staging/10-vpc/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = ">= 3.37.0"
version = ">= 5.31.0"
}
}

Expand Down
16 changes: 8 additions & 8 deletions terraform-modules/aws/vpc/main.tf
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module "vpc" {
source = "terraform-aws-modules/vpc/aws"
version = "3.7.0"
version = "5.4.0"

name = var.environment_name
cidr = var.vpc_cidr
Expand Down Expand Up @@ -38,14 +38,14 @@ module "vpc" {
"kubernetes.io/role/internal-elb" = "1"
"ops_purpose" = "Overloaded for k8s worker usage"
}

tags = var.tags

#Default Security Group Management (Default: secure)
manage_default_security_group = var.manage_default_security_group
default_security_group_name = var.default_security_group_name
default_security_group_egress = var.default_security_group_egress
default_security_group_ingress = var.default_security_group_ingress
default_security_group_tags = var.default_security_group_tags
manage_default_security_group = var.manage_default_security_group
default_security_group_name = var.default_security_group_name
default_security_group_egress = var.default_security_group_egress
default_security_group_ingress = var.default_security_group_ingress
default_security_group_tags = var.default_security_group_tags

}