Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPC version Error enable_classiclink #449

Open
ArslanAhmet opened this issue Oct 2, 2023 · 5 comments
Open

VPC version Error enable_classiclink #449

ArslanAhmet opened this issue Oct 2, 2023 · 5 comments

Comments

@ArslanAhmet
Copy link

ArslanAhmet commented Oct 2, 2023

I got errors related to the version of the VPC module according to my understanding of issue.

When I used as source below:
github.com/ManagedKube/kubernetes-ops//terraform-modules/aws/vpc?ref=v2.0.85
I got below errors
Error: Unsupported argument

│ on .terraform/modules/vpc.vpc/main.tf line 32, in resource "aws_vpc" "this":
│ 32: enable_classiclink = var.enable_classiclink

│ An argument named "enable_classiclink" is not expected here.


│ Error: Unsupported argument

│ on .terraform/modules/vpc.vpc/main.tf line 33, in resource "aws_vpc" "this":
│ 33: enable_classiclink_dns_support = var.enable_classiclink_dns_support

│ An argument named "enable_classiclink_dns_support" is not expected here.


│ Error: Unsupported argument

│ on .terraform/modules/vpc.vpc/main.tf line 1315, in resource "aws_default_vpc" "this":
│ 1315: enable_classiclink = var.default_vpc_enable_classiclink

│ An argument named "enable_classiclink" is not expected here.

Operation failed: failed running terraform plan (exit 1)

According to documentation enable_classiclink is removed with terraform VPC version of 5.0.0 but kubernetes-ops version is still using "3.7.0"

source = "terraform-aws-modules/vpc/aws"
version = "3.7.0"

Is there a need for upgrade?

@henryjarend
Copy link

Was this ever resolved? I'm running into this as well

@ArslanAhmet
Copy link
Author

Do not waste time with Terraform. I left and I'm happy now. Cloud environments are developed very fast, global solutions can not adapt to those changes in time. Libraries are getting old very quickly. Instead of using a single IaC, I recommend using vendor specific IaC. I did not experience similar problems with cloud formation for AWS.

@yiskaneto
Copy link

yiskaneto commented Dec 18, 2023

Was this ever resolved? I'm running into this as well

I've got a PR which resolves the mentioned issue #453

@henryjarend
Copy link

I dropped the module (I actually got rid of all the managedkube modules) and got rid of the issue.

@yiskaneto
Copy link

yiskaneto commented Dec 18, 2023

I dropped the module (I actually got rid of all the managedkube modules) and got rid of the issue.

that makes sense, the project hasn't been updated in a while, I happened to came across this repo and wanted to give it a try and after checking, the changes it needed were minimal to get it to work. In general you want to use the terraform vpc module directly using Terragrunt to keep conf dry, but that's just an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants