-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): multiple instructors are formatted properly, displays last name only, and are capitalized in all course blocks (#342) #403
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: src/views/hooks/useFlattenedCourseSchedule.ts
Did you find this useful? React with a 👍 or 👎 |
src/views/components/injected/CourseCatalogInjectedPopup/HeadingAndActions.tsx
Outdated
Show resolved
Hide resolved
src/views/components/injected/CourseCatalogInjectedPopup/HeadingAndActions.tsx
Show resolved
Hide resolved
…eral Co-authored-by: Samuel Gunter <[email protected]>
…m/adityamkk/UT-Registration-Plus into fix/multiple-instructor-name-view
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM, awaiting UI/UX review from @IsaDavRod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This PR resolves (#342)
The issue was improper formatting of multiple instructors in course blocks in the calendar and main extension popup.
Here are the changes:
Calendar Course Block after the changes:
Main Extension Popup Course Block after the changes:
This change is