Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): multiple instructors are formatted properly, displays last name only, and are capitalized in all course blocks (#342) #403

Conversation

adityamkk
Copy link
Contributor

@adityamkk adityamkk commented Oct 29, 2024

This PR resolves (#342)
The issue was improper formatting of multiple instructors in course blocks in the calendar and main extension popup.

Here are the changes:

  1. Instructor names in course blocks now only display last names
  2. Instructor names are spaced with a semicolon in the calendar and main extension popup

Calendar Course Block after the changes:
image

Main Extension Popup Course Block after the changes:
image


This change is Reviewable

Copy link

sentry-io bot commented Oct 29, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/views/hooks/useFlattenedCourseSchedule.ts

Function Unhandled Issue
extractCourseInfo Error: Invalid Instructor String format: first_last Instructor.toString(../../src/shared/types/Instructor....
Event Count: 5 Affected Users: 2

Did you find this useful? React with a 👍 or 👎

Copy link
Collaborator

@Samathingamajig Samathingamajig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM, awaiting UI/UX review from @IsaDavRod

Copy link
Member

@IsaDavRod IsaDavRod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Samathingamajig Samathingamajig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@IsaDavRod IsaDavRod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samathingamajig Samathingamajig merged commit 50e88fa into Longhorn-Developers:main Oct 29, 2024
6 checks passed
@IsaDavRod IsaDavRod linked an issue Oct 29, 2024 that may be closed by this pull request
4 tasks
Copy link

sentry-io bot commented Nov 7, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: Invalid Instructor String format: first_last Instructor.toString(../../src/shared/types/Inst... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix course block instructor text when a course has more than one instructor.
3 participants