Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix course block instructor text when a course has more than one instructor. #342

Closed
4 tasks
IsaDavRod opened this issue Oct 20, 2024 · 0 comments · Fixed by #403
Closed
4 tasks

Fix course block instructor text when a course has more than one instructor. #342

IsaDavRod opened this issue Oct 20, 2024 · 0 comments · Fixed by #403
Assignees

Comments

@IsaDavRod
Copy link
Member

IsaDavRod commented Oct 20, 2024

  • (Additional task for all courses, regardless of number of instructors) Only include instructor's last name for course blocks in calendar view instead of full name. If a course has two instructors, then separate last names by semicolon.

  • For course blocks in Calendar View, ensure both instructor's last names are shown, separated by a comma.

  • For course blocks in the Main Extension Popup, ensure both instructor's last names are shown, separated by a semicolon.

  • For all course blocks in the Main Extension Popup, title-case instructor's last name instead of it being all capitalized

Image
Image

Image

Huly®: UTRP-338

@IsaDavRod IsaDavRod converted this from a draft issue Oct 20, 2024
Samathingamajig added a commit that referenced this issue Oct 29, 2024
…ame only, and are capitalized in all course blocks (#342) (#403)

* fix(ui): updated multiple instructor name formatting in course blocks

* fix(ui): display instructor last names only in all course blocks

* refactor: use instructor toString when getting instructor full name

* refactor: toString in useFlattenedCourseSchedule without template literal

Co-authored-by: Samuel Gunter <[email protected]>

* refactor: delete type hint and unnecessary comments

* fix(ui): instructor names semicolon delimiter in calendar course block

* fix(ui): removed 'unknown' when there are no instructors

* fix(ui): change - to &ndash

* fix(ui): changed - to ndash in hook

---------

Co-authored-by: Samuel Gunter <[email protected]>
@github-project-automation github-project-automation bot moved this from Ready to Done in UTRP Bug Tracker Oct 29, 2024
@IsaDavRod IsaDavRod removed the status in UTRP Bug Tracker Oct 29, 2024
@IsaDavRod IsaDavRod moved this to Done in UTRP Bug Tracker Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants