Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: instructor formatting errors #425

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Samathingamajig
Copy link
Collaborator

@Samathingamajig Samathingamajig commented Nov 12, 2024

yep, it's ugly code, but I fixed the errors 👍


This change is Reviewable

@Samathingamajig
Copy link
Collaborator Author

fixes this issue on main: https://www.chromatic.com/test?appId=65c5172964f36dcf207985bf&id=6732f9e81c8197002f208ace

this wasn't detected earlier because we're broke
image
https://www.chromatic.com/build?appId=65c5172964f36dcf207985bf&number=1857
https://github.com/Longhorn-Developers/UT-Registration-Plus/actions/runs/11770378080/job/32782716245

Snapshot quota reached
This build is limited because your account is out of snapshots for the month.

@Samathingamajig
Copy link
Collaborator Author

resolves these sentry errors

image

@Samathingamajig
Copy link
Collaborator Author

caused by #403

see comment #403 (comment)

@Samathingamajig
Copy link
Collaborator Author

ugh isaiah doesn't like "Unknown" anymore, which requires some weird code changes

also need some weird code changes for RMP and CES to make sure instructor names are valid globally in the component so that we don't have the button not be disabled when it should be

@Samathingamajig Samathingamajig marked this pull request as draft November 12, 2024 15:19
@doprz doprz self-requested a review November 12, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant