-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: don't use KonnectClient in ClientsProvider #6885
Conversation
ba03ed5
to
7b8e093
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6885 +/- ##
=====================================
Coverage 76.7% 76.8%
=====================================
Files 214 214
Lines 25139 25170 +31
=====================================
+ Hits 19299 19338 +39
+ Misses 4825 4820 -5
+ Partials 1015 1012 -3 ☔ View full report in Codecov by Sentry. |
984e8a6
to
1d7e311
Compare
285a836
to
abddf7d
Compare
abddf7d
to
6dc3c92
Compare
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/12650457940 |
a62eafb
to
54aa11f
Compare
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/12651092822 |
54aa11f
to
3ec4762
Compare
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/12652101132 |
3ec4762
to
08e17f9
Compare
08e17f9
to
3f13774
Compare
2d33eeb
to
5889552
Compare
0eb7f99
to
c35991a
Compare
c35991a
to
e9d2fb5
Compare
What this PR does / why we need it:
Stop using
KonnectClient
in the clients' provider. Makekonnect.ConfigSynchronizer
create one using a factory on its startup instead. Also:konnect.ConfigSynchronizer
.deckgen.ToDeckContent
fromKongClient
tokonnect.ConfigSynchronizer
as it may reach out to Konnect APIs while for plugins schemas, and we don't want to spend time on Konnect-related stuff in the critical pathWhich issue this PR fixes:
Part of #6340.