Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: don't use KonnectClient in ClientsProvider #6885

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Dec 20, 2024

What this PR does / why we need it:

Stop using KonnectClient in the clients' provider. Make konnect.ConfigSynchronizer create one using a factory on its startup instead. Also:

  • moves tests related to Konnect-specific behavior to konnect.ConfigSynchronizer.
  • moves the call to deckgen.ToDeckContent from KongClient to konnect.ConfigSynchronizer as it may reach out to Konnect APIs while for plugins schemas, and we don't want to spend time on Konnect-related stuff in the critical path

Which issue this PR fixes:

Part of #6340.

@czeslavo czeslavo self-assigned this Dec 20, 2024
@czeslavo czeslavo added area/konnect Issues and PRs related to Konnect and removed size/XL labels Dec 20, 2024
@czeslavo czeslavo force-pushed the chore/remove-konnect-from-kongclient branch 4 times, most recently from ba03ed5 to 7b8e093 Compare December 23, 2024 09:29
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 62.29508% with 69 lines in your changes missing coverage. Please review.

Project coverage is 76.8%. Comparing base (40d909f) to head (e9d2fb5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/manager/run.go 0.0% 23 Missing ⚠️
internal/konnect/config_synchronizer.go 81.5% 17 Missing and 2 partials ⚠️
internal/adminapi/konnect.go 0.0% 14 Missing ⚠️
internal/manager/setup.go 0.0% 13 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #6885   +/-   ##
=====================================
  Coverage   76.7%   76.8%           
=====================================
  Files        214     214           
  Lines      25139   25170   +31     
=====================================
+ Hits       19299   19338   +39     
+ Misses      4825    4820    -5     
+ Partials    1015    1012    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czeslavo czeslavo force-pushed the chore/remove-konnect-from-kongclient branch 5 times, most recently from 984e8a6 to 1d7e311 Compare December 23, 2024 14:56
@czeslavo czeslavo force-pushed the chore/remove-konnect-from-kongclient branch 2 times, most recently from 285a836 to abddf7d Compare January 7, 2025 11:11
@czeslavo czeslavo added the ci/run-e2e Trigger e2e test run from PR label Jan 7, 2025
@czeslavo czeslavo force-pushed the chore/remove-konnect-from-kongclient branch from abddf7d to 6dc3c92 Compare January 7, 2025 11:13
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/12650457940

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Jan 7, 2025
@czeslavo czeslavo force-pushed the chore/remove-konnect-from-kongclient branch 2 times, most recently from a62eafb to 54aa11f Compare January 7, 2025 11:57
@czeslavo czeslavo added the ci/run-e2e Trigger e2e test run from PR label Jan 7, 2025
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/12651092822

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Jan 7, 2025
@czeslavo czeslavo force-pushed the chore/remove-konnect-from-kongclient branch from 54aa11f to 3ec4762 Compare January 7, 2025 13:00
@czeslavo czeslavo added the ci/run-e2e Trigger e2e test run from PR label Jan 7, 2025
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/12652101132

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Jan 7, 2025
@czeslavo czeslavo force-pushed the chore/remove-konnect-from-kongclient branch from 3ec4762 to 08e17f9 Compare January 7, 2025 13:03
@czeslavo czeslavo marked this pull request as ready for review January 7, 2025 13:26
@czeslavo czeslavo requested a review from a team as a code owner January 7, 2025 13:26
@czeslavo czeslavo force-pushed the chore/remove-konnect-from-kongclient branch from 08e17f9 to 3f13774 Compare January 7, 2025 13:49
internal/dataplane/sendconfig/dbmode.go Outdated Show resolved Hide resolved
internal/konnect/config_synchronizer.go Outdated Show resolved Hide resolved
internal/konnect/config_synchronizer.go Show resolved Hide resolved
internal/dataplane/kong_client.go Outdated Show resolved Hide resolved
internal/konnect/config_synchronizer.go Outdated Show resolved Hide resolved
@czeslavo czeslavo force-pushed the chore/remove-konnect-from-kongclient branch from 2d33eeb to 5889552 Compare January 7, 2025 16:36
@czeslavo czeslavo force-pushed the chore/remove-konnect-from-kongclient branch from 0eb7f99 to c35991a Compare January 8, 2025 08:36
@czeslavo czeslavo requested a review from programmer04 January 8, 2025 08:37
@czeslavo czeslavo force-pushed the chore/remove-konnect-from-kongclient branch from c35991a to e9d2fb5 Compare January 8, 2025 08:49
@czeslavo czeslavo merged commit 0be255a into main Jan 8, 2025
42 checks passed
@czeslavo czeslavo deleted the chore/remove-konnect-from-kongclient branch January 8, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/konnect Issues and PRs related to Konnect size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants