Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: don't use KonnectClient in ClientsProvider #6885

Merged
merged 4 commits into from
Jan 8, 2025

return ctx.Err() from NodeAgent

e9d2fb5
Select commit
Loading
Failed to load commit list.
Merged

chore: don't use KonnectClient in ClientsProvider #6885

return ctx.Err() from NodeAgent
e9d2fb5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 8, 2025 in 0s

76.8% (+0.0%) compared to 40d909f

View this Pull Request on Codecov

76.8% (+0.0%) compared to 40d909f

Details

Codecov Report

Attention: Patch coverage is 62.29508% with 69 lines in your changes missing coverage. Please review.

Project coverage is 76.8%. Comparing base (40d909f) to head (e9d2fb5).

Files with missing lines Patch % Lines
internal/manager/run.go 0.0% 23 Missing ⚠️
internal/konnect/config_synchronizer.go 81.5% 17 Missing and 2 partials ⚠️
internal/adminapi/konnect.go 0.0% 14 Missing ⚠️
internal/manager/setup.go 0.0% 13 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #6885   +/-   ##
=====================================
  Coverage   76.7%   76.8%           
=====================================
  Files        214     214           
  Lines      25139   25170   +31     
=====================================
+ Hits       19299   19338   +39     
+ Misses      4825    4820    -5     
+ Partials    1015    1012    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.