Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Konnect synchronizer use client from clients provider #6905

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

randmonkey
Copy link
Contributor

What this PR does / why we need it:

Konnect config synchronizer uses clientProvider.KonnectClient() to fetch Konnect client. This prevents the issue happen in the scenario where initializing Konnect is slow and synchronizer did not receive the client on creating, then the synchronizer cannot get the client.

Which issue this PR fixes:

Fixes #6904
Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@randmonkey randmonkey requested a review from a team as a code owner December 27, 2024 03:27
@randmonkey randmonkey added ci/run-e2e Trigger e2e test run from PR and removed size/L labels Dec 27, 2024
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/12511350747

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Dec 27, 2024
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.9%. Comparing base (6ca4eee) to head (0599be7).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/manager/setup.go 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #6905     +/-   ##
=======================================
+ Coverage   76.5%   76.9%   +0.4%     
=======================================
  Files        212     214      +2     
  Lines      25246   25139    -107     
=======================================
+ Hits       19321   19342     +21     
+ Misses      4912    4780    -132     
- Partials    1013    1017      +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

programmer04
programmer04 previously approved these changes Jan 7, 2025
@czeslavo
Copy link
Contributor

czeslavo commented Jan 7, 2025

Please hold on - #6885 will fix this issue. In #6868 I overlooked that getting the KonnectClient right away in the setup will have such consequences, but it was intended to be temporary until #6885 gets merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e test case TestKonnectConfigPush fails
4 participants