updated storage_pool

[G-NamanGupta]

Fixes - #15842

This PR is to support provisioning storage pool for Google Cloud NetApp Volumes through GCP terraform provider.

`google_netapp_storage_pool`

This pull request is duplicate to #8954.
Creating this pull request as the above one was having some git commits without correct author.

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[c2thorn]

reassigning @shuyama1 from #8954

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 12 files changed, 1371 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 12 files changed, 1371 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 166 insertions(+))
TF OiCS: Diff ( 4 files changed, 137 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3143
Passed tests 2826
Skipped tests: 316
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetappstoragePool_storagePoolCreateExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNetappstoragePool_storagePoolCreateExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[G-NamanGupta]

Hi @shuyama1 ,

I've added 'projectNumberDiffSuppress' to this to get rid of that project id/number.
also, can you please paste the error log here? is there any way for us to see the error log by ourselves?

[shuyama1]

@G-NamanGupta sorry for the delay on reviewing it. The test failed due to

vcr_utils.go:152: Resource specified by ResourceName couldn't be found: google_netapp_storage_pool.test_pool 

Sorry we currently can't expose the debug logs to externals. Apologize for the inconvenience :(

[G-NamanGupta]

Hi @shuyama1, I've updated the test file.
Not sure how to run test here again.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 12 files changed, 1371 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 12 files changed, 1371 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 166 insertions(+))
TF OiCS: Diff ( 4 files changed, 137 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3143
Passed tests 2824
Skipped tests: 318
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetappstoragePool_storagePoolCreateExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNetappstoragePool_storagePoolCreateExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[shuyama1]

vcr_utils.go:152: Failed state verification, resource with ID projects/ci-test-project-188019/locations/us-central1/storagePools/ not found

Are you able to run the test and get it pass locally? Let me know if you need help debugging

[G-NamanGupta]

Hi @shuyama1 ,

I just added id_format field in yaml file, It was not mentioned in the magic module documentation in basic structure. Now I can successfully run the automated test in my local. Can you please trigger the test?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 12 files changed, 1371 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 12 files changed, 1371 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 166 insertions(+))
TF OiCS: Diff ( 4 files changed, 137 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3149
Passed tests 2827
Skipped tests: 317
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccNetappstoragePool_storagePoolCreateExample|TestAccSpannerInstanceIamPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]
TestAccNetappstoragePool_storagePoolCreateExample[Debug log]
TestAccSpannerInstanceIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 14 files changed, 1391 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 14 files changed, 1391 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 146 insertions(+))
TF OiCS: Diff ( 4 files changed, 129 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3234
Passed tests 2903
Skipped tests: 330
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetappstoragePool_storagePoolCreateExample_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetappstoragePool_storagePoolCreateExample_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[shuyama1]

LGTM. Will wait for the service team to confirm if all current fields are supported and immutable flags are added correctly before merging this PR.

[okrause]

@shuyama1 Any updates on the progress?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 14 files changed, 1404 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 14 files changed, 1404 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 146 insertions(+))
TF OiCS: Diff ( 4 files changed, 129 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3238
Passed tests 2907
Skipped tests: 330
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataprocJobIamPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocJobIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[shuyama1]

Thank you!