Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated storage_pool #9229
updated storage_pool #9229
Changes from all commits
ac6d4f0
4fa0c96
cc4d924
40fc3ca
ad79d45
b0f9dac
34b7f51
3391ac4
8b1dff1
4a8cf61
0bdc597
6d4be14
d88b23a
a70eb9e
381d908
3b5930f
83dc848
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's change the values of the fields to be different from what's in
testAccNetappstoragePool_storagePoolCreateExample_full
to test the update of these fields. If any of the fields can be updated, we'll need to mark them asimmutable
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've marked immutable: true to the fields which I believe are not updatable as best of my knowledge as it's not mentioned in the API documentation about which fields are immutable or not. Please have a look at it and let me know if there is any other change I'm supposed to do here.