Added volume module for Google Cloud NetApp Volume #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added volume module * Added updated function and network fix * updated update test fields. * updated unixPermissions field. * updated test file for snapshot_policy * updated description. updated test file with basic example and function name. * removed the *_UNSPECIFIED values for inputs Default values for minutes, hours, days and day_of_week in snapshot block Updated tests to incorporate suggestions by shuya Fixes some indentation in tests Updates some test to get better test coverage commented restoreParamters as suggested by Shuya. * updated tests to use us-west1 region * updated region to us-west2 [upstream:bd6b1b34069c41459496f838c32a8014af9a8dc2] Signed-off-by: Modular Magician <[email protected]>
modular-magician
merged commit 5ab6fd2
into
terraform-google-modules:master
1 check passed
modular-magician
deleted the
downstream-pr-bd6b1b34069c41459496f838c32a8014af9a8dc2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes hashicorp/terraform-provider-google#16019
This PR is to support provisioning volume for Google Cloud NetApp Volumes through GCP terraform provider.
This is extension to GoogleCloudPlatform/magic-modules#9229
Derived from GoogleCloudPlatform/magic-modules#9513