fix: check if 'lineTypeIntelligence' property exists #3758
Conversation
vindard
force-pushed
the
fix-missing-type-property
branch
from
ccbc61f to
7685fb0
Compare
| @@ -10,6 +10,9 @@ export class RestrictedRegionPhoneProviderError extends PhoneProviderServiceErro | |||
| export class UnsubscribedRecipientPhoneProviderError extends PhoneProviderServiceError {} | |||
| export class RestrictedRecipientPhoneNumberError extends PhoneProviderServiceError {} | |||
| export class InvalidOrApprovedVerificationError extends PhoneProviderServiceError {} | |||
| export class MissingTypePhoneProviderError extends PhoneProviderServiceError { | |||
| level = ErrorLevel.Critical | |||
There was a problem hiding this comment.
I'm not sure we should have Critical for this error? not sure in what scenario we would not have this, but this seems to be expected from twilio at times and not much we could do when that scenario arises?
There was a problem hiding this comment.
this should not be critical, we cant control external service response
There was a problem hiding this comment.
My thinking was to just flag this as critical for now but to identify what's happening more clearly so that we can look into if we should downgrade it to not alert us, or if it can serve as a proxy that something is wrong with the general service.
In the last month or so it's only comes up 4 time out of thousands of calls (traces)
If we think it's better to swallow the error alert now though I can make that change
| @@ -10,6 +10,9 @@ export class RestrictedRegionPhoneProviderError extends PhoneProviderServiceErro | |||
| export class UnsubscribedRecipientPhoneProviderError extends PhoneProviderServiceError {} | |||
| export class RestrictedRecipientPhoneNumberError extends PhoneProviderServiceError {} | |||
| export class InvalidOrApprovedVerificationError extends PhoneProviderServiceError {} | |||
| export class MissingTypePhoneProviderError extends PhoneProviderServiceError { | |||
| level = ErrorLevel.Critical | |||
There was a problem hiding this comment.
this should not be critical, we cant control external service response
| @@ -57,6 +58,9 @@ export const TwilioClient = (): IPhoneProviderService => { | |||
| fields: "line_type_intelligence", | |||
| }) | |||
| // https://www.twilio.com/docs/lookup/v2-api/line-type-intelligence#type-property-values | |||
| if (!lookup.lineTypeIntelligence) { | |||
There was a problem hiding this comment.
do we really want to stop sending the code if lineTypeIntelligence is not defined?
Description
Improves visibility for this trace