fix: check if 'lineTypeIntelligence' property exists (#3758)

GaloyMoney · Dec 28, 2023 · 3eb3ed3 · 3eb3ed3
1 parent 8ce9ff4
commit 3eb3ed3
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/core/api/src/domain/phone-provider/errors.ts b/core/api/src/domain/phone-provider/errors.ts
@@ -10,6 +10,9 @@ export class RestrictedRegionPhoneProviderError extends PhoneProviderServiceErro
 export class UnsubscribedRecipientPhoneProviderError extends PhoneProviderServiceError {}
 export class RestrictedRecipientPhoneNumberError extends PhoneProviderServiceError {}
 export class InvalidOrApprovedVerificationError extends PhoneProviderServiceError {}
+export class MissingTypePhoneProviderError extends PhoneProviderServiceError {
+  level = ErrorLevel.Critical
+}
 
 export class PhoneCodeInvalidError extends PhoneProviderServiceError {}
 

diff --git a/core/api/src/graphql/error-map.ts b/core/api/src/graphql/error-map.ts
@@ -179,6 +179,10 @@ export const mapError = (error: ApplicationError): CustomGraphQLError => {
       message = "Invalid phone number type. Please use a mobile number."
       return new ValidationInternalError({ message, logger: baseLogger })
 
+    case "MissingTypePhoneProviderError":
+      message = "Issue checking phone number. Please try again later or contact support."
+      return new ValidationInternalError({ message, logger: baseLogger })
+
     case "RestrictedRegionPhoneProviderError":
       message = "Phone number is not from a valid region"
       return new ValidationInternalError({ message, logger: baseLogger })

diff --git a/core/api/src/services/twilio-service.ts b/core/api/src/services/twilio-service.ts
@@ -16,6 +16,7 @@ import {
   InvalidOrApprovedVerificationError,
   InvalidPhoneNumberPhoneProviderError,
   InvalidTypePhoneProviderError,
+  MissingTypePhoneProviderError,
   PhoneCodeInvalidError,
   PhoneProviderConnectionError,
   PhoneProviderRateLimitExceededError,
@@ -57,6 +58,9 @@ export const TwilioClient = (): IPhoneProviderService => {
         fields: "line_type_intelligence",
       })
       // https://www.twilio.com/docs/lookup/v2-api/line-type-intelligence#type-property-values
+      if (!lookup.lineTypeIntelligence) {
+        return new MissingTypePhoneProviderError()
+      }
       if (lookup.lineTypeIntelligence.type === "nonFixedVoip") {
         return new InvalidTypePhoneProviderError("nonFixedVoip")
       }