Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if 'lineTypeIntelligence' property exists #3758

Merged
merged 1 commit into from
Dec 28, 2023
Merged

fix: check if 'lineTypeIntelligence' property exists #3758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/api/src/domain/phone-provider/errors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ export class RestrictedRegionPhoneProviderError extends PhoneProviderServiceErro
export class UnsubscribedRecipientPhoneProviderError extends PhoneProviderServiceError {}
export class RestrictedRecipientPhoneNumberError extends PhoneProviderServiceError {}
export class InvalidOrApprovedVerificationError extends PhoneProviderServiceError {}
export class MissingTypePhoneProviderError extends PhoneProviderServiceError {
level = ErrorLevel.Critical
Copy link
Member

@nicolasburtey nicolasburtey Dec 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we should have Critical for this error? not sure in what scenario we would not have this, but this seems to be expected from twilio at times and not much we could do when that scenario arises?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be critical, we cant control external service response

Copy link
Contributor Author

@vindard vindard Dec 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thinking was to just flag this as critical for now but to identify what's happening more clearly so that we can look into if we should downgrade it to not alert us, or if it can serve as a proxy that something is wrong with the general service.

In the last month or so it's only comes up 4 time out of thousands of calls (traces)

If we think it's better to swallow the error alert now though I can make that change

}

export class PhoneCodeInvalidError extends PhoneProviderServiceError {}

Expand Down
4 changes: 4 additions & 0 deletions core/api/src/graphql/error-map.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,10 @@ export const mapError = (error: ApplicationError): CustomGraphQLError => {
message = "Invalid phone number type. Please use a mobile number."
return new ValidationInternalError({ message, logger: baseLogger })

case "MissingTypePhoneProviderError":
message = "Issue checking phone number. Please try again later or contact support."
return new ValidationInternalError({ message, logger: baseLogger })

case "RestrictedRegionPhoneProviderError":
message = "Phone number is not from a valid region"
return new ValidationInternalError({ message, logger: baseLogger })
Expand Down
4 changes: 4 additions & 0 deletions core/api/src/services/twilio-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import {
InvalidOrApprovedVerificationError,
InvalidPhoneNumberPhoneProviderError,
InvalidTypePhoneProviderError,
MissingTypePhoneProviderError,
PhoneCodeInvalidError,
PhoneProviderConnectionError,
PhoneProviderRateLimitExceededError,
Expand Down Expand Up @@ -57,6 +58,9 @@ export const TwilioClient = (): IPhoneProviderService => {
fields: "line_type_intelligence",
})
// https://www.twilio.com/docs/lookup/v2-api/line-type-intelligence#type-property-values
if (!lookup.lineTypeIntelligence) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really want to stop sending the code if lineTypeIntelligence is not defined?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3758 (comment)

return new MissingTypePhoneProviderError()
}
if (lookup.lineTypeIntelligence.type === "nonFixedVoip") {
return new InvalidTypePhoneProviderError("nonFixedVoip")
}
Expand Down
Loading