Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONOTMERGE] Fix constraints and constraint test files per issue #773 #828

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Rene2mt
Copy link
Member

@Rene2mt Rene2mt commented Oct 28, 2024

Committer Notes

This PR makes constraint, baseline, and example content (a.k.a. "template") updates to resolve issue #773

Specifically, it makes the following changes:

  • For FedRAMP extension properties, changes namespace from "https://fedramp.gov/ns/oscal" to "http://fedramp.gov/ns/oscal"
  • For the SSP identifier-type, changes the value from "https://fedramp.gov/ns/oscal" to "http://fedramp.gov/ns/oscal"
  • For POA&M facets, changes the system flag from "https://fedramp.gov" to "http://fedramp.gov/ns/oscal"

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rene2mt, I assume we are staging this PR for discussion on Wednesday, if I get your message and our previous conversations?

Either way, thanks for putting this work together. This will be useful to drive discussion.

@Rene2mt Rene2mt linked an issue Oct 31, 2024 that may be closed by this pull request
16 tasks
@DimitriZhurkin
Copy link

Sorry to chime in quite late. I think all files in the latest branch already have instances of http:/ replaced with https:/.

Apologies if I'm off the track.

DimitriZhurkin
DimitriZhurkin previously approved these changes Nov 18, 2024
@Rene2mt Rene2mt force-pushed the issue-773-option2-constaints branch from b42bdc3 to b727064 Compare November 27, 2024 22:10
@Rene2mt Rene2mt force-pushed the issue-773-option2-constaints branch from b727064 to 19654d1 Compare December 12, 2024 21:25
@Rene2mt Rene2mt marked this pull request as ready for review December 12, 2024 21:28
@Rene2mt Rene2mt requested a review from a team as a code owner December 12, 2024 21:28
@Gabeblis
Copy link
Contributor

Gabeblis commented Dec 13, 2024

Is the goal to update every occurrence of ns="https..." in the repo? If so, this seems a little light.

@Rene2mt Rene2mt force-pushed the issue-773-option2-constaints branch from 19654d1 to b244ff0 Compare December 13, 2024 16:38
@wandmagic
Copy link
Collaborator

Any chance we can just use gov.fedramp.oscal namespace? Makes more sense to me

@Gabeblis Gabeblis mentioned this pull request Dec 13, 2024
7 tasks
@aj-stein-gsa
Copy link
Contributor

Any chance we can just use gov.fedramp.oscal namespace? Makes more sense to me

I mean could we? Sure. Is it valid within the spec of URIs? Not quite, especially when you consider we have a full URI with a subpath, so you are proposing gov.fedramp.oscal/ns/oscal in full?

Technically speaking (because we are that kind of group), reverse DNS notation is not how an actual domain works in a URI, more details in the official RFC about the host requirement.

@aj-stein-gsa aj-stein-gsa changed the title Fix constraints and constraint test files per issue #773 [DONOTMERGE] Fix constraints and constraint test files per issue #773 Dec 13, 2024
@wandmagic
Copy link
Collaborator

wandmagic commented Dec 13, 2024

then could we just have fedramp.gov/ns/oscal? the confusing part for me is when i see http i expect to be able to send traffic to that domain over http protocol

As the Metaschema documentation describes the URI data type with that RFC, the short answer is nope. Scheme is not optional AFAICT.

https://datatracker.ietf.org/doc/html/rfc3986#section-3

Interesting that we do not enforce this through matches or something akin to that, I will look into that upstream actually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align prop and misc identifier requirements for the official FedRAMP namespace
5 participants