-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DONOTMERGE] Fix constraints and constraint test files per issue #773 #828
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rene2mt, I assume we are staging this PR for discussion on Wednesday, if I get your message and our previous conversations?
Either way, thanks for putting this work together. This will be useful to drive discussion.
Sorry to chime in quite late. I think all files in the latest branch already have instances of Apologies if I'm off the track. |
b42bdc3
to
b727064
Compare
b727064
to
19654d1
Compare
Is the goal to update every occurrence of |
19654d1
to
b244ff0
Compare
Any chance we can just use gov.fedramp.oscal namespace? Makes more sense to me |
I mean could we? Sure. Is it valid within the spec of URIs? Not quite, especially when you consider we have a full URI with a subpath, so you are proposing Technically speaking (because we are that kind of group), reverse DNS notation is not how an actual domain works in a URI, more details in the official RFC about the host requirement. |
As the Metaschema documentation describes the URI data type with that RFC, the short answer is nope. Scheme is not optional AFAICT. https://datatracker.ietf.org/doc/html/rfc3986#section-3 Interesting that we do not enforce this through |
Committer Notes
This PR makes constraint, baseline, and example content (a.k.a. "template") updates to resolve issue #773
Specifically, it makes the following changes:
identifier-type
, changes the value from "https://fedramp.gov/ns/oscal" to "http://fedramp.gov/ns/oscal"facets
, changes thesystem
flag from "https://fedramp.gov" to "http://fedramp.gov/ns/oscal"All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.