Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Namespace Issue #773 #998

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Gabeblis
Copy link
Contributor

Committer Notes

Purpose

This PR makes constraint, baseline, and example content updates to resolve issue #773.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis self-assigned this Dec 13, 2024
@Gabeblis Gabeblis requested a review from a team as a code owner December 13, 2024 17:33
@Gabeblis Gabeblis linked an issue Dec 13, 2024 that may be closed by this pull request
16 tasks
@Gabeblis
Copy link
Contributor Author

@Rene2mt I just opened this PR for reference, but it looks like there were some gaps. I believe mostly from the new constraints added since you originally opened PR #828.

@aj-stein-gsa
Copy link
Contributor

So how do we want to handle this, I am comparing but you both are consistent with the @ns but the facet and system items for other field values and flags, so I am comparing this diff comparing the two directly before weighing in I guess.

https://github.com/Rene2mt/fedramp-automation/compare/issue-773-option2-constaints..Gabeblis:fedramp-automation:constraints/issue-773

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align prop and misc identifier requirements for the official FedRAMP namespace
2 participants